Revision: 6643
http://languagetool.svn.sourceforge.net/languagetool/?rev=6643&view=rev
Author: dnaber
Date: 2012-03-25 00:59:28 +0000 (Sun, 25 Mar 2012)
Log Message:
-----------
fix bug #3179433: assume both directions of the quotes are in use
(?\194?\187...?\194?\171 and ?\194?\171...?\194?\187) - we used to create a
false alarm with the unexpected quotes
Modified Paths:
--------------
trunk/JLanguageTool/src/java/org/languagetool/language/Galician.java
trunk/JLanguageTool/src/java/org/languagetool/language/German.java
trunk/JLanguageTool/src/java/org/languagetool/language/Italian.java
trunk/JLanguageTool/src/java/org/languagetool/language/Romanian.java
trunk/JLanguageTool/src/java/org/languagetool/language/Slovak.java
trunk/JLanguageTool/src/java/org/languagetool/language/Slovenian.java
trunk/JLanguageTool/src/java/org/languagetool/language/Spanish.java
trunk/JLanguageTool/src/java/org/languagetool/language/Ukrainian.java
trunk/JLanguageTool/src/test/org/languagetool/rules/GenericUnpairedBracketsRuleTest.java
Modified: trunk/JLanguageTool/src/java/org/languagetool/language/Galician.java
===================================================================
--- trunk/JLanguageTool/src/java/org/languagetool/language/Galician.java
2012-03-25 00:14:12 UTC (rev 6642)
+++ trunk/JLanguageTool/src/java/org/languagetool/language/Galician.java
2012-03-25 00:59:28 UTC (rev 6643)
@@ -76,12 +76,12 @@
@Override
public String[] getUnpairedRuleStartSymbols() {
- return new String[]{ "[", "(", "{", "“", "«", "‘", "\"", "'" };
+ return new String[]{ "[", "(", "{", "“", "«", "»", "‘", "\"", "'" };
}
@Override
public String[] getUnpairedRuleEndSymbols() {
- return new String[]{ "]", ")", "}", "”", "»", "’", "\"", "'" };
+ return new String[]{ "]", ")", "}", "”", "»", "«", "’", "\"", "'" };
}
@Override
Modified: trunk/JLanguageTool/src/java/org/languagetool/language/German.java
===================================================================
--- trunk/JLanguageTool/src/java/org/languagetool/language/German.java
2012-03-25 00:14:12 UTC (rev 6642)
+++ trunk/JLanguageTool/src/java/org/languagetool/language/German.java
2012-03-25 00:59:28 UTC (rev 6643)
@@ -55,12 +55,12 @@
@Override
public String[] getUnpairedRuleStartSymbols() {
- return new String[]{ "[", "(", "{", "„", "»", "‘" };
+ return new String[]{ "[", "(", "{", "„", "»", "«", "‘" };
}
@Override
public String[] getUnpairedRuleEndSymbols() {
- return new String[]{ "]", ")", "}", "“", "«", "’" };
+ return new String[]{ "]", ")", "}", "“", "«", "»", "’" };
}
@Override
Modified: trunk/JLanguageTool/src/java/org/languagetool/language/Italian.java
===================================================================
--- trunk/JLanguageTool/src/java/org/languagetool/language/Italian.java
2012-03-25 00:14:12 UTC (rev 6642)
+++ trunk/JLanguageTool/src/java/org/languagetool/language/Italian.java
2012-03-25 00:59:28 UTC (rev 6643)
@@ -51,12 +51,12 @@
@Override
public String[] getUnpairedRuleStartSymbols() {
- return new String[]{ "[", "(", "{", "»", /*"‘"*/ };
+ return new String[]{ "[", "(", "{", "»", "«" /*"‘"*/ };
}
@Override
public String[] getUnpairedRuleEndSymbols() {
- return new String[]{ "]", ")", "}", "«", /*"’"*/ };
+ return new String[]{ "]", ")", "}", "«", "»" /*"’"*/ };
}
@Override
Modified: trunk/JLanguageTool/src/java/org/languagetool/language/Romanian.java
===================================================================
--- trunk/JLanguageTool/src/java/org/languagetool/language/Romanian.java
2012-03-25 00:14:12 UTC (rev 6642)
+++ trunk/JLanguageTool/src/java/org/languagetool/language/Romanian.java
2012-03-25 00:59:28 UTC (rev 6643)
@@ -74,12 +74,12 @@
@Override
public String[] getUnpairedRuleStartSymbols() {
- return new String[]{ "[", "(", "{", "„", "«" };
+ return new String[]{ "[", "(", "{", "„", "«", "»" };
}
@Override
public String[] getUnpairedRuleEndSymbols() {
- return new String[]{ "]", ")", "}", "”", "»" };
+ return new String[]{ "]", ")", "}", "”", "»", "«" };
}
@Override
Modified: trunk/JLanguageTool/src/java/org/languagetool/language/Slovak.java
===================================================================
--- trunk/JLanguageTool/src/java/org/languagetool/language/Slovak.java
2012-03-25 00:14:12 UTC (rev 6642)
+++ trunk/JLanguageTool/src/java/org/languagetool/language/Slovak.java
2012-03-25 00:59:28 UTC (rev 6643)
@@ -59,12 +59,12 @@
@Override
public String[] getUnpairedRuleStartSymbols() {
- return new String[]{ "[", "(", "{", "„", "»", "\"" };
+ return new String[]{ "[", "(", "{", "„", "»", "«", "\"" };
}
@Override
public String[] getUnpairedRuleEndSymbols() {
- return new String[]{ "]", ")", "}", "“", "«", "\"" };
+ return new String[]{ "]", ")", "}", "“", "«", "»", "\"" };
}
@Override
Modified: trunk/JLanguageTool/src/java/org/languagetool/language/Slovenian.java
===================================================================
--- trunk/JLanguageTool/src/java/org/languagetool/language/Slovenian.java
2012-03-25 00:14:12 UTC (rev 6642)
+++ trunk/JLanguageTool/src/java/org/languagetool/language/Slovenian.java
2012-03-25 00:59:28 UTC (rev 6643)
@@ -51,12 +51,12 @@
@Override
public String[] getUnpairedRuleStartSymbols() {
- return new String[]{ "[", "(", "{", "„", "»", "\"" };
+ return new String[]{ "[", "(", "{", "„", "»", "«", "\"" };
}
@Override
public String[] getUnpairedRuleEndSymbols() {
- return new String[]{ "]", ")", "}", "”", "«", "\"" };
+ return new String[]{ "]", ")", "}", "”", "«", "»", "\"" };
}
@Override
Modified: trunk/JLanguageTool/src/java/org/languagetool/language/Spanish.java
===================================================================
--- trunk/JLanguageTool/src/java/org/languagetool/language/Spanish.java
2012-03-25 00:14:12 UTC (rev 6642)
+++ trunk/JLanguageTool/src/java/org/languagetool/language/Spanish.java
2012-03-25 00:59:28 UTC (rev 6643)
@@ -70,12 +70,12 @@
@Override
public String[] getUnpairedRuleStartSymbols() {
- return new String[]{ "[", "(", "{", "“", "«", "¿", "¡" };
+ return new String[]{ "[", "(", "{", "“", "«", "»", "¿", "¡" };
}
@Override
public String[] getUnpairedRuleEndSymbols() {
- return new String[]{ "]", ")", "}", "”", "»", "?", "!" };
+ return new String[]{ "]", ")", "}", "”", "»", "«", "?", "!" };
}
@Override
Modified: trunk/JLanguageTool/src/java/org/languagetool/language/Ukrainian.java
===================================================================
--- trunk/JLanguageTool/src/java/org/languagetool/language/Ukrainian.java
2012-03-25 00:14:12 UTC (rev 6642)
+++ trunk/JLanguageTool/src/java/org/languagetool/language/Ukrainian.java
2012-03-25 00:59:28 UTC (rev 6643)
@@ -56,12 +56,12 @@
@Override
public String[] getUnpairedRuleStartSymbols() {
- return new String[]{ "[", "(", "{", "„", "«" };
+ return new String[]{ "[", "(", "{", "„", "«", "»" };
}
@Override
public String[] getUnpairedRuleEndSymbols() {
- return new String[]{ "]", ")", "}", "“", "»" };
+ return new String[]{ "]", ")", "}", "“", "»", "«" };
}
@Override
Modified:
trunk/JLanguageTool/src/test/org/languagetool/rules/GenericUnpairedBracketsRuleTest.java
===================================================================
---
trunk/JLanguageTool/src/test/org/languagetool/rules/GenericUnpairedBracketsRuleTest.java
2012-03-25 00:14:12 UTC (rev 6642)
+++
trunk/JLanguageTool/src/test/org/languagetool/rules/GenericUnpairedBracketsRuleTest.java
2012-03-25 00:59:28 UTC (rev 6643)
@@ -41,13 +41,19 @@
RuleMatch[] matches;
JLanguageTool langTool = new JLanguageTool(Language.GERMAN);
// correct sentences:
- matches = rule.match(langTool
- .getAnalyzedSentence("(Das sind die Sätze, die die testen sollen)."));
+ matches = rule.match(langTool.getAnalyzedSentence("(Das sind die Sätze,
die die testen sollen)."));
assertEquals(0, matches.length);
+ matches = rule.match(langTool.getAnalyzedSentence("(Das sind die «Sätze»,
die die testen sollen)."));
+ assertEquals(0, matches.length);
+ matches = rule.match(langTool.getAnalyzedSentence("(Das sind die »Sätze«,
die die testen sollen)."));
+ assertEquals(0, matches.length);
// incorrect sentences:
- matches = rule
- .match(langTool.getAnalyzedSentence("Die „Sätze zum testen."));
+ matches = rule.match(langTool.getAnalyzedSentence("Die „Sätze zum
testen."));
assertEquals(1, matches.length);
+ matches = rule.match(langTool.getAnalyzedSentence("Die «Sätze zum
testen."));
+ assertEquals(1, matches.length);
+ matches = rule.match(langTool.getAnalyzedSentence("Die »Sätze zum
testen."));
+ assertEquals(1, matches.length);
}
public void testRuleSpanish() throws IOException {
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here
http://p.sf.net/sfu/sfd2d-msazure
_______________________________________________
Languagetool-cvs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/languagetool-cvs
