On 05/21/2013 06:11 PM, Daniel Naber wrote:
> Am 21.05.2013 04:35, schrieb Andriy Rysin:
>
>> ok, one more question ignoreWord() in SpellingCheckRule has these two
>> lines:
>> // TODO?: this is needed at least for German as Hunspell
>> tokenization includes the dot:
>> final String cleanWord = word.endsWith(".") ? word.substring(0,
>> word.length() - 1) : word;
>>
>> it prevents me from checking words with dots against the ignore.txt
>> list. Is this line really needed in common code?
>
> It's needed when the Hunspell WORDCHARS option contains a dot. The
> easiest way to see if code actually has an effect is often to comment
> out the code and then run the tests cases. In this case, a (rather
> obscure) test won't work anymore.
Ok, I've added a code to skip this line if ignore list had words with
dots. For now it's true only for Ukrainian so no other language is affected.
As for the ignoreToken: I've added ignoreToken() to SpellingCheckRule
but left ignoreWord() not deprecated as ignoreToken() (and Ukrainian
module) is using it to match the word against the ignore list. We could
deprecate it later but for now I could not find a quick way to do it
cleanly.
Regards,
Andriy
------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may
_______________________________________________
Languagetool-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/languagetool-devel
