Hi Daniel I was thinking about regex but didn't want to overcomplicate or slow down the logic. But inconsistency you pointed definitely is not good. I've pushed the change.
Thanks, Andriy 2013/12/3 Daniel Naber <list2...@danielnaber.de>: > On 2013-12-02 22:58, Andriy Rysin wrote: > >> ahh, my apologies it was committed but never pushed (too much >> distraction lately), should be in repository now. > > Thanks, it's there and I did some tiny whitespace cleanups. There is > also another issue which I just found: compoundChar is once used as a > string, then as a regex: > > 1. word.contains(compoundChar) > 2. word.split(compoundChar) > > I think it should be a regex, and the variable and methods should be > called compoundRegex. What do you think? Could you change that? > > Regards > Daniel > > -- > http://www.danielnaber.de > > > ------------------------------------------------------------------------------ > Rapidly troubleshoot problems before they affect your business. Most IT > organizations don't have a clear picture of how application performance > affects their revenue. With AppDynamics, you get 100% visibility into your > Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! > http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk > _______________________________________________ > Languagetool-devel mailing list > Languagetool-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/languagetool-devel ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk _______________________________________________ Languagetool-devel mailing list Languagetool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/languagetool-devel
