On 11/28/2014 11:34 AM, Daniel Naber wrote: > On 2014-11-28 17:07, Andriy Rysin wrote: > > Hi Andriy, > >> Here's updated version of the patch to fix index out of bounds >> exception >> in German tests. >> Now all language tests pass. > thanks for the patch. I currently don't have to time to properly review > it, but it would be nice if you could write a test that fails without > this patch, i.e. that demonstrates the original problem. That plus all > existing tests working seems good enough to commit it. Hi Daniel
I've added a test and made sure all existing tests pass and pushed the change in. That said I had to add a line (adding a matcher) to make the new test pass (by taking new code path). I don't quite understand why and although this seem to work for in in xml rules there still may be some code path that is still taking the old logic. So I would appreciate the code review when you have a chance. I left comments where code or test was was very obvious (at least to me :)) Thanks Andriy ------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk _______________________________________________ Languagetool-devel mailing list Languagetool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/languagetool-devel
