I have pushed a change to SpellDictionaryBuilder to require -o <outputFile> option. I tried to make the changes small so there's probably room for improvement.
If this approach works we can use the same for other dictionary builders. Andriy 2014-12-23 11:58 GMT-05:00 Dominique Pellé <dominique.pe...@gmail.com>: > Hi > > I have this script... > > languagetool/languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/create-lexicon.sh > > ... which works by assuming that SynthDictionaryBuilder java > program creates its output files in /tmp/... > > But it would be trivial to modify the script if -o option is added > which will make the script simpler and more robust. > > Above script even has a comment saying... > > # The Java program outputs temporary files in /tmp which is not > # convenient (it would be better to indicate the location of output files). > > > So I'm also in favor of of making -o option mandatory. > > Regards > Dominique > > > Andriy Rysin <ary...@gmail.com> wrote: > >> That may break existing scripts that depende on that, is everybody ok >> with such a change? >> >> Regards, >> Andriy >> >> 2014-12-23 3:41 GMT-05:00 Daniel Naber <daniel.na...@languagetool.org>: >>> On 2014-12-23 04:55, Andriy Rysin wrote: >>> >>>> 2) I would like to suggest adding -o <outputFile> option to >>>> *DictionaryBuilder, as writing output to random tmp file makes >>>> scripting harder; I already have local changes working (using >>>> apache.cli library) so if nobody objects I will clean up the code and >>>> will push it in (the option will be optional so old way will still >>>> work) >>> >>> I'd even suggest to make it non-optional, that will probably keep the >>> code simpler. >>> >>> Regards >>> Daniel >>> >>> >>> ------------------------------------------------------------------------------ >>> Dive into the World of Parallel Programming! The Go Parallel Website, >>> sponsored by Intel and developed in partnership with Slashdot Media, is your >>> hub for all things parallel software development, from weekly thought >>> leadership blogs to news, videos, case studies, tutorials and more. Take a >>> look and join the conversation now. http://goparallel.sourceforge.net >>> _______________________________________________ >>> Languagetool-devel mailing list >>> Languagetool-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/languagetool-devel >> >> ------------------------------------------------------------------------------ >> Dive into the World of Parallel Programming! The Go Parallel Website, >> sponsored by Intel and developed in partnership with Slashdot Media, is your >> hub for all things parallel software development, from weekly thought >> leadership blogs to news, videos, case studies, tutorials and more. Take a >> look and join the conversation now. http://goparallel.sourceforge.net >> _______________________________________________ >> Languagetool-devel mailing list >> Languagetool-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/languagetool-devel > > ------------------------------------------------------------------------------ > Dive into the World of Parallel Programming! The Go Parallel Website, > sponsored by Intel and developed in partnership with Slashdot Media, is your > hub for all things parallel software development, from weekly thought > leadership blogs to news, videos, case studies, tutorials and more. Take a > look and join the conversation now. http://goparallel.sourceforge.net > _______________________________________________ > Languagetool-devel mailing list > Languagetool-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/languagetool-devel ------------------------------------------------------------------------------ Dive into the World of Parallel Programming! The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net _______________________________________________ Languagetool-devel mailing list Languagetool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/languagetool-devel
