So in JLanguageToolTest.testAnalyzedSentence() (line 133) the expected reading for token with soft hyphen excpects testÂed/null, but I don't really understand this logic. The last related commit I found was a refactoring (f44e90d1f00c87ef3728d3ac7d8502add8311142). As I understand we use token readings with null tag to show we could not tag the token. But what's the value of additional reading with null tag? I don't mind adjusting my rules but I'd like to fully understand the logic before I do so :)
Thanks Andriy 2015-01-18 14:26 GMT-05:00 Daniel Naber <daniel.na...@languagetool.org>: > On 2015-01-16 05:19, Andriy Rysin wrote: > >> Here's a PoC patch to allow ignoring arbitrary characters when >> analyzing text. > > Some ideas: > > -add "@since 2.9" to the new public methods > -a test case would be nice > > About the "if( false )": do all the tests still work with that? Maybe > have a look in the file history to see what it is for. > >> We could change regex into array of chars and use for loop/indexOf >> (this should still be faster than regexp for several characters). > > I don't think this is necessary, unless a performance test shows that > it's worth it. > > Regards > Daniel > > > ------------------------------------------------------------------------------ > New Year. New Location. New Benefits. New Data Center in Ashburn, VA. > GigeNET is offering a free month of service with a new server in Ashburn. > Choose from 2 high performing configs, both with 100TB of bandwidth. > Higher redundancy.Lower latency.Increased capacity.Completely compliant. > http://p.sf.net/sfu/gigenet > _______________________________________________ > Languagetool-devel mailing list > Languagetool-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/languagetool-devel ------------------------------------------------------------------------------ New Year. New Location. New Benefits. New Data Center in Ashburn, VA. GigeNET is offering a free month of service with a new server in Ashburn. Choose from 2 high performing configs, both with 100TB of bandwidth. Higher redundancy.Lower latency.Increased capacity.Completely compliant. http://p.sf.net/sfu/gigenet _______________________________________________ Languagetool-devel mailing list Languagetool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/languagetool-devel
