On 2016-01-28 13:30, Marcin Miłkowski wrote: > I would also add a new list of valency attributes to every > AnalyzedToken, simply as a string value (parsing the string would be > overkill because there might be different ways of encoding valency > information for different languages), with appropriate getters and > setters.
Just a general remark on a technical level: where possible, I suggest moving away from setters and try to initialize everything in the constructor (or a separate builder class). This way we can have immutable objects, which makes it easier to build robust and thread-safe software. AnalyzedToken isn't immutable anyway, but still I suggest moving in that direction. Regards Daniel ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140 _______________________________________________ Languagetool-devel mailing list Languagetool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/languagetool-devel
