Author: ptw
Date: 2006-11-09 14:07:58 -0800 (Thu, 09 Nov 2006)
New Revision: 2460
Modified:
openlaszlo/branches/legals/WEB-INF/lps/lfc/debugger/LzFormat.lzs
Log:
Change 20061108-ptw-b by [EMAIL PROTECTED] on 2006-11-08 16:08:18 EST
in /Users/ptw/OpenLaszlo/legals-2/WEB-INF/lps/lfc
Summary: formatToString depended on invalid JS semantics
Bugs Fixed:
LPP-NaN: testFormat failed: Equals: expected \" 0000.00" got
?\194?\171debugger/LzMessage.lzs#19/17#56(8)#55| "000 0.00"?\194?\187
Technical Reviewer: henry (verbal, 2006-11-09)
QA Reviewer: mamye (pending)
Doc Reviewer: n/a
Details:
Number(' ') is NaN in swf. It should be +0, per ECMA:
?\226?\128?\162 A StringNumericLiteral that is empty or contains only white
space is converted to +0.
I was really just looking to see if the number had a leading sign
(or space), so do that.
Tests:
test/smoke/simple.lzx, which includes the debugger format test.
Modified: openlaszlo/branches/legals/WEB-INF/lps/lfc/debugger/LzFormat.lzs
===================================================================
--- openlaszlo/branches/legals/WEB-INF/lps/lfc/debugger/LzFormat.lzs
2006-11-09 21:58:10 UTC (rev 2459)
+++ openlaszlo/branches/legals/WEB-INF/lps/lfc/debugger/LzFormat.lzs
2006-11-09 22:07:58 UTC (rev 2460)
@@ -177,6 +177,7 @@
} else {
sign = null;
if (pad != ' ') {
+ // Need to move sign to left of padding
if (" +-".indexOf(str.substring(0, 1)) >= 0) {
sign = str.substring(0, 1);
str = str.substring(1);
_______________________________________________
Laszlo-checkins mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-checkins
