Author: ben
Date: 2007-06-29 14:52:38 -0700 (Fri, 29 Jun 2007)
New Revision: 5560
Modified:
openlaszlo/branches/legals/lps/components/lzunit/lzunit.lzx
Log:
Change 20070621-ben-x by [EMAIL PROTECTED] on 2007-06-21 15:34:48 PDT
in /Users/ben/src/svn/openlaszlo/branches/legals
for http://svn.openlaszlo.org/openlaszlo/branches/legals
Summary:
New Features:
Bugs Fixed: LPP-4109 DHTML Smokecheck - output is erased, so you can't tell if
it succeeded
Technical Reviewer: ptw
QA Reviewer: (pending)
Doc Reviewer: (pending)
Documentation:
The tests in a TestSuite needn't be laid out with a simplelayout; it is more
interesting to put them all on top of eachother, so you can see them. More
importantly, though, taking out the simplelayout allows the focus to jump
to views in different tests without scrolling the test output off the screen.
To make sure we can see the test output, we bring the controlPanel to front
after calling each test.
Release Notes:
Details:
Tests:
http://localhost:8080/legals/test/lzunit/lzunit-console-failure-test.lzx?lzr=dhtml&debug=true
notice that the tests fail, and you can see the red bar. (before this fix,
the red bar would disappear)
Files:
M lps/components/lzunit/lzunit.lzx
Modified: openlaszlo/branches/legals/lps/components/lzunit/lzunit.lzx
===================================================================
--- openlaszlo/branches/legals/lps/components/lzunit/lzunit.lzx 2007-06-29
21:21:22 UTC (rev 5559)
+++ openlaszlo/branches/legals/lps/components/lzunit/lzunit.lzx 2007-06-29
21:52:38 UTC (rev 5560)
@@ -1149,6 +1149,11 @@
}
var c = new LzDelegate( this , "runNextTest" )
LzIdle.callOnIdle(c);
+ // This fix papers over a difference between swf and dhtml, and
I'm not sure
+ // why this fixes it. In dhtml, without this change, the control
panel
+ // becomes invisible when the tests fail, but in swf, we don't see
that problem.
+ // in any case, this fixes bug LPP-4109 [bshine 2007.06.29]
+ this.controlPanel.bringToFront(); // make sure we can see the control
panel
return true;
]]>
</method>
@@ -1171,8 +1176,6 @@
@keywords private
-->
- <simplelayout axis="y" spacing="10" />
-
<!-- default view of the TestResult -->
<view name="controlPanel" height="100%" width="100%">
<simplelayout axis="y" spacing="10" />
@@ -1182,7 +1185,6 @@
width="100%" height="100%"
/>
</view>
-
</class>
_______________________________________________
Laszlo-checkins mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-checkins
