Author: hqm
Date: 2007-08-09 11:03:19 -0700 (Thu, 09 Aug 2007)
New Revision: 5980
Modified:
openlaszlo/branches/wafflecone/WEB-INF/lps/lfc/data/LzDataElement.lzs
openlaszlo/branches/wafflecone/WEB-INF/lps/lfc/data/LzDataNode.lzs
Log:
Change 20070809-hqm-8 by [EMAIL PROTECTED] on 2007-08-09 12:08:48 EDT
in /cygdrive/c/users/hqm/openlaszlo/wafflecone
for http://svn.openlaszlo.org/openlaszlo/branches/wafflecone
Summary: fix for selectParent bug on LzDataText
New Features:
Bugs Fixed: LPP-4453
Bug: LPP-4453
Technical Reviewer: max
QA Reviewer: promanik
Doc Reviewer: (pending)
Documentation:
Release Notes:
Details:
The legals-refactored code for datapointer expects selectParent to find a
getParent method,
which is only defined on LzDataElement now. Fix is to move that getParent
method to the common
LzDataNode class. Also moved getOffset to LzDataNode.
Tests:
test case in bug report
Modified: openlaszlo/branches/wafflecone/WEB-INF/lps/lfc/data/LzDataElement.lzs
===================================================================
--- openlaszlo/branches/wafflecone/WEB-INF/lps/lfc/data/LzDataElement.lzs
2007-08-09 16:32:27 UTC (rev 5979)
+++ openlaszlo/branches/wafflecone/WEB-INF/lps/lfc/data/LzDataElement.lzs
2007-08-09 18:03:19 UTC (rev 5980)
@@ -267,13 +267,6 @@
return [ this , "childNodes" ];
}
-/**
- * Returns the parent of this node
- * @return LzDataNode: the parent of this node
- */
-function getParent () {
- return this.parentNode;
-}
/**
* @access private
@@ -285,17 +278,7 @@
this.__LZcoDirty = false;
}
-/**
- * gets offset of node in parent's childNodes array
- * @return number
- */
-function getOffset (){
- if (!this.parentNode) return 0;
- if (this.parentNode.__LZcoDirty) this.parentNode.__LZupdateCO();
- return this.__LZo;
-}
-
/**
* @access private
*/
Modified: openlaszlo/branches/wafflecone/WEB-INF/lps/lfc/data/LzDataNode.lzs
===================================================================
--- openlaszlo/branches/wafflecone/WEB-INF/lps/lfc/data/LzDataNode.lzs
2007-08-09 16:32:27 UTC (rev 5979)
+++ openlaszlo/branches/wafflecone/WEB-INF/lps/lfc/data/LzDataNode.lzs
2007-08-09 18:03:19 UTC (rev 5980)
@@ -91,6 +91,25 @@
}
/**
+ * Returns the parent of this node
+ * @return LzDataNode: the parent of this node
+ */
+function getParent () {
+ return this.parentNode;
+}
+
+/**
+ * gets offset of node in parent's childNodes array
+ * @return number
+ */
+function getOffset (){
+ if (!this.parentNode) return 0;
+ if (this.parentNode.__LZcoDirty) this.parentNode.__LZupdateCO();
+
+ return this.__LZo;
+}
+
+/**
* @access private
*/
prototype.getPreviousSibling.dependencies = function( who, self ){
_______________________________________________
Laszlo-checkins mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-checkins
