Author: ben
Date: 2007-08-10 11:17:28 -0700 (Fri, 10 Aug 2007)
New Revision: 6004
Added:
openlaszlo/branches/wafflecone/lps/components/incubator/rich-text/test/richtexteditarea-driver.lzx
Modified:
openlaszlo/branches/wafflecone/lps/components/incubator/rich-text/formatfontcolor.lzx
Log:
Change 20070809-ben-u by [EMAIL PROTECTED] on 2007-08-09 14:30:16 PDT
in /Users/ben/src/svn/openlaszlo/branches/wafflecone
for http://svn.openlaszlo.org/openlaszlo/branches/wafflecone
Summary: Explicitly hook up font color combobox to editor's font color
New Features:
Bugs Fixed: LPP-4461 In rich text editor, font color combo box does not update
when cursor moves to different colored text
Technical Reviewer: max
QA Reviewer: mkratt (pending)
Doc Reviewer: (pending)
Documentation:
This change is more of the process of making connections between the editor and
the
editing components explicit. When the editor is hooked up to the font color
combo box, the
font color combo box must change its color to match the color of the editor's
default
font color. This sounds like doubletalk, but it's actually more like
quadrupletalk.
Release Notes:
Details:
In order for the font color combo box to match the color of the default font of
the
associated editor, the default font of the editor *must* be one of the color
options
in the fontcolors dataset.
Tests:
http://localhost:8080/wafflecone/lps/components/incubator/rich-text/test/richtexteditarea-driver.lzx?debug=true&lzr=swf8
Select some text. Choose a color. Move the cursor to some other text. The color
combo box should take on the color of the text it is currently in. Select some
more text, set it's color. Move the cursor between text of various colors, and
the color combo box should always update to match the color of the text at the
current insertion point.
Modified:
openlaszlo/branches/wafflecone/lps/components/incubator/rich-text/formatfontcolor.lzx
===================================================================
---
openlaszlo/branches/wafflecone/lps/components/incubator/rich-text/formatfontcolor.lzx
2007-08-10 18:03:38 UTC (rev 6003)
+++
openlaszlo/branches/wafflecone/lps/components/incubator/rich-text/formatfontcolor.lzx
2007-08-10 18:17:28 UTC (rev 6004)
@@ -34,7 +34,7 @@
itemclassname="colorswatch" itemdatapath="fontcolors:/clr"
focusable="false" listwidth="${this.bkgnd.mid.width}">
- <attribute name="editor" value="$once{this.parent.editor}" />
+ <attribute name="editor" />
<attribute name="toolbar" value="$once{this.parent}" />
<tooltip>Choose font color</tooltip>
@@ -45,9 +45,18 @@
<method name="init">
super.init();
toolbar.registerTool(this,"color");
+ </method>
+
+ <!-- When we get an editor to hook up to, make this menu's value
+ match up to the default color of the editor.
+ Fixes LPP-4461: In rich text editor, font color combo box does
+ not update when cursor moves to different colored text
+ [bshine 08.09.2007] -->
+ <method event="oneditor" args="e">
this.setValue(this.editor.defaultfontcolor, true);
- this.csq.setColor(this.editor.defaultfontcolor);
+ this.csq.setColor(this.editor.defaultfontcolor);
</method>
+
<!--- @keywords private
apply state for late instantiation of local data -->
<method name="construct" args="parent, args">
Added:
openlaszlo/branches/wafflecone/lps/components/incubator/rich-text/test/richtexteditarea-driver.lzx
Property changes on:
openlaszlo/branches/wafflecone/lps/components/incubator/rich-text/test/richtexteditarea-driver.lzx
___________________________________________________________________
Name: svn:mime-type
+ text/xml
Name: svn:eol-style
+ native
_______________________________________________
Laszlo-checkins mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-checkins
