Author: max
Date: 2007-08-14 17:28:24 -0700 (Tue, 14 Aug 2007)
New Revision: 6057

Modified:
   openlaszlo/branches/wafflecone/WEB-INF/lps/lfc/core/LzNode.lzs
   openlaszlo/branches/wafflecone/WEB-INF/lps/lfc/kernel/swf/LzTextSprite.as
   openlaszlo/branches/wafflecone/WEB-INF/lps/lfc/services/LzCSSStyle.js
Log:
Change 20070814-maxcarlson-j by [EMAIL PROTECTED] on 2007-08-14 16:34:59 PDT
    in /Users/maxcarlson/openlaszlo/wafflecone
    for http://svn.openlaszlo.org/openlaszlo/branches/wafflecone

Summary: LFC cleanup

New Features:

Bugs Fixed: LPP-4414 - Improve startup performance (partial)

Technical Reviewer: promanik
QA Reviewer: ptw
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details: LzTextSprite.as - Clean up font name lookups.

LzCSSStyle.js - Fix assignment to free variable t in services/LzCSSStyle.js 
(thanks Tucker!)

LzNode.lzs - Add a note to a recent CSS styling fix referencing the bug number 
it fixed.
    

Tests: 'cd WEB-INF/lps/lfc/; ant;' no longer warns about the unassigned 
variable.



Modified: openlaszlo/branches/wafflecone/WEB-INF/lps/lfc/core/LzNode.lzs
===================================================================
--- openlaszlo/branches/wafflecone/WEB-INF/lps/lfc/core/LzNode.lzs      
2007-08-15 00:17:02 UTC (rev 6056)
+++ openlaszlo/branches/wafflecone/WEB-INF/lps/lfc/core/LzNode.lzs      
2007-08-15 00:28:24 UTC (rev 6057)
@@ -518,6 +518,7 @@
         if (! (k in initialArgs)) {
             // A style that is a function is a constraint
             if (v instanceof Function) {
+                //Only set styleConstraints[k] if this[k] is null.  See 
LPP-2894 - CSS: subclasses and instances can't override style constraints set 
on superclass* 
                 if (this[k] == null) {
 //                    Debug.warn("setting %w[%w] to %w, was %w", this, k, v, 
this[k]);
                     styleConstraints[k] = v;

Modified: 
openlaszlo/branches/wafflecone/WEB-INF/lps/lfc/kernel/swf/LzTextSprite.as
===================================================================
--- openlaszlo/branches/wafflecone/WEB-INF/lps/lfc/kernel/swf/LzTextSprite.as   
2007-08-15 00:17:02 UTC (rev 6056)
+++ openlaszlo/branches/wafflecone/WEB-INF/lps/lfc/kernel/swf/LzTextSprite.as   
2007-08-15 00:28:24 UTC (rev 6057)
@@ -626,12 +626,8 @@
   */
 LzTextSprite.prototype.__setFormat = function (){
     this.setFontInfo();
-    var mapped = LzFontManager.__fontnameCacheMap[this.fontname];
-    var cfontname;
-    if (mapped != null) {
-        //Debug.write("found cached font", this.fontname, mapped);
-        cfontname = mapped;
-    } else {
+    var cfontname = LzFontManager.__fontnameCacheMap[this.fontname];
+    if (cfontname == null) {
         cfontname = LzFontManager.__findMatchingFont(this.fontname);
         LzFontManager.__fontnameCacheMap[this.fontname] = cfontname;
         //Debug.write("caching fontname", this.fontname, cfontname);

Modified: openlaszlo/branches/wafflecone/WEB-INF/lps/lfc/services/LzCSSStyle.js
===================================================================
--- openlaszlo/branches/wafflecone/WEB-INF/lps/lfc/services/LzCSSStyle.js       
2007-08-15 00:17:02 UTC (rev 6056)
+++ openlaszlo/branches/wafflecone/WEB-INF/lps/lfc/services/LzCSSStyle.js       
2007-08-15 00:28:24 UTC (rev 6057)
@@ -462,7 +462,7 @@
     while (curnode != canvas){
         //recursively loop through selectors, ensuring each applies to the 
current node or a parent 
         var nrp = rp[sindex]
-        t = nrp.type;
+        var t = nrp.type;
 
         if ( t == this._sel_star ||
             (t == this._sel_id && nrp.id == curnode.id) ||


_______________________________________________
Laszlo-checkins mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-checkins

Reply via email to