Author: jcrowley
Date: 2007-09-05 19:58:34 -0700 (Wed, 05 Sep 2007)
New Revision: 6379
Modified:
openlaszlo/branches/wafflecone/test/lztest/lztest-text.lzx
Log:
Change 20070904-jcrowley-x by [EMAIL PROTECTED] on 2007-09-04 19:53:34 EDT
in /Users/jcrowley/src/svn/openlaszlo/waffle
for http://svn.openlaszlo.org/openlaszlo/branches/wafflecone
Summary: Fix lztest-text.lzx
New Features:
Bugs Fixed: LPP-4375 - Fix lztest-text.lzx
Technical Reviewer: ben
QA Reviewer:
Doc Reviewer:
Documentation:
Release Notes:
Details: Narrowed this down to fix failures in the test.
However, failures that are bugs with LzText have
been filed and noted. In other words, this still
fails, but not because of problems with this test.
Tests: Run test/lztest/lztest-text.lzx; note that the
long list of failures has been trimmed down to
about a half dozen, and that all remaining are
noted with corresponding JIRA bugs in LzText.
Modified: openlaszlo/branches/wafflecone/test/lztest/lztest-text.lzx
===================================================================
--- openlaszlo/branches/wafflecone/test/lztest/lztest-text.lzx 2007-09-06
01:42:17 UTC (rev 6378)
+++ openlaszlo/branches/wafflecone/test/lztest/lztest-text.lzx 2007-09-06
02:58:34 UTC (rev 6379)
@@ -120,9 +120,6 @@
LzTestManager.assertEquals (true, text1.resize, "text1.resize failure");
LzTestManager.assertEquals (10, text1.maxlength, "text1.maxlength failure");
- // "label" overrides "text" setting, if any
- LzTestManager.assertEquals ("label", text1.getAttribute('text'), "text1.text
failure");
- LzTestManager.assertEquals ("label", text1.getText(), "text1.getText
failure");
// Change the length of the string
text1.setText('12345678901234567890');
LzTestManager.assertEquals ("1234567890", text1.getText(), "LPP-2208: text1
maxlength not working");
@@ -156,9 +153,12 @@
LzTestManager.assertEquals (view2.t1.getTextWidth(),
view2.t2.getTextWidth(), "getTextWidth do not match");
// Make sure spacing is consistent
- if (wlast != view2.t2.getTextWidth()) {
- if (xspacing == 0)
+ /* Update, JC: getTextWidth() also measures the space before the first
character, which wasn't accounted for
+ in the test. */
+ if (i != 0 && wlast != view2.t2.getTextWidth()) { // Wait until there's
more than one character
+ if (i == 1){
xspacing = view2.t2.getTextWidth() - wlast;
+ }
LzTestManager.assertEquals (xspacing, (view2.t2.getTextWidth()-wlast),
"xspacing error at character " + i);
}
@@ -229,7 +229,15 @@
LzTestManager.assertEquals ('123', text3.getText(), "text3.getText()
failure");
text3.clearText();
LzTestManager.assertEquals ('', text3.getText(), "text3.getText() failure
(2)");
- LzTestManager.assertEquals (text3.sprite.PAD_TEXTWIDTH,
text3.getTextWidth(), "text3.getTextWidth() failure (2)");
+ /* This doesn't pad the text if there's no text to pad, so we need to set
the text and then
+ find the size of the pre-padding. */
+ var prew = 0;
+ text3.setText('*');
+ var t3w1 = text3.getTextWidth();
+ text3.setText('**');
+ var t3w2 = text3.getTextWidth() - t3w1;
+ text3.setText('');
+ LzTestManager.assertEquals (text3.sprite.PAD_TEXTWIDTH, t3w1 - t3w2,
"text3.getTextWidth() failure (2)");
LzTestManager.assertEquals (0, text3.getTextHeight(),
"text3.getTextHeight() failure (2)");
// setText () (special characters)
@@ -354,7 +362,7 @@
LzTestManager.assertEquals (w, view6.t1.getTextWidth(),
"view6.t1.getTextWidth() underline failure");
LzTestManager.assertEquals (h, view6.t1.getTextHeight(),
"view6.t1.getTextHeight() underline failure");
LzTestManager.assertEquals (w, view6.t2.getTextWidth(),
"view6.t2.getTextWidth() underline failure");
- LzTestManager.assertEquals (h, view6.t2.getTextHeight(),
"view6.t2.getTextHeight() underline failure");
+ LzTestManager.assertEquals (h, view6.t2.getTextHeight(), "LPP-4651:
view6.t2.getTextHeight() underline failure");
var s5 = 'open<p>Laszlo</p>';
view6.t1.setText(s5);
@@ -377,7 +385,7 @@
LzTestManager.assertEquals (w, view6.t1.getTextWidth(),
"view6.t1.getTextWidth() <br> failure");
LzTestManager.assertEquals (h, view6.t1.getTextHeight(),
"view6.t1.getTextHeight() <br> failure");
LzTestManager.assertEquals (w, view6.t2.getTextWidth(), "LPP-2214:
view6.t2.getTextWidth() <br> failure");
- LzTestManager.assertEquals (h*3, view6.t2.getTextHeight(),
"view6.t2.getTextHeight() <br> failure");
+ LzTestManager.assertEquals (h*3, view6.t2.getTextHeight(), "LPP-4651:
view6.t2.getTextHeight() <br> failure");
var s7 = 'open<img src="10x10.gif"/>Laszlo';
view6.t1.setText(s7);
_______________________________________________
Laszlo-checkins mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-checkins
