Author: ben
Date: 2007-12-19 14:50:14 -0800 (Wed, 19 Dec 2007)
New Revision: 7624
Modified:
openlaszlo/trunk/docs/src/xsl/common-html.xsl
Log:
Change 20071219-ben-Q by [EMAIL PROTECTED] on 2007-12-19 14:42:49 PST
in /Users/ben/src/svn/openlaszlo/trunk
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: Doc tools improvements -- don't load DHTML lfc, specify history: false
New Features:
Bugs Fixed: LPP-5270 $3.startExec is not a function firebug error in
embed-compressed.js
LPP-5298 Generated documentation should not include LFCdhtml.js
LPP-5207 change height of example code window from 200 to 400 pixels
Technical Reviewer: none
QA reviewer: liorio
Documentation:
Discussion with Max revealed that we should pass in "history: false" when we
call
Lz.swfEmbed( ... ) for a live example, so that we don't irritate the history
mechanism. This makes hundreds of firebug errors go away on every page of the
developer's guide.
Also, it is just not necessary to include LFCdhtml.js when we're not planning to
include any dhtml live examples at this point!
This change also finally makes it so that the default height of embedded
examples is
400. I'm not sure why this change does that, but it did, so, rejoice.
Tests:
ant clean developers
visit http://localhost:8080/trunk/docs/developers/color.html note that there
are no firebug errors
same with
http://localhost:8080/trunk/docs/developers/tutorials/laszlo_basics.html
Modified: openlaszlo/trunk/docs/src/xsl/common-html.xsl
===================================================================
--- openlaszlo/trunk/docs/src/xsl/common-html.xsl 2007-12-19 22:49:23 UTC
(rev 7623)
+++ openlaszlo/trunk/docs/src/xsl/common-html.xsl 2007-12-19 22:50:14 UTC
(rev 7624)
@@ -115,7 +115,6 @@
<script type="text/javascript" language="JavaScript"
src="{$rootpath}{$root.relative.lps.includes}embed-compressed.js"/>
<script type="text/javascript" language="JavaScript"
src="{$rootpath}includes/docs.js"/>
<script type="text/javascript" language="JavaScript"><xsl:text>lzOptions =
{ ServerRoot: '</xsl:text><xsl:value-of select="$rootpath"/><xsl:text>',
dhtmlKeyboardControl: false };</xsl:text></script>
- <script type="text/javascript"
language="JavaScript"><xsl:text>Lz.dhtmlEmbedLFC('</xsl:text><xsl:value-of
select="$rootpath"/><xsl:text>/lps/includes/lfc/LFCdhtml.js');</xsl:text></script>
</xsl:template>
<xsl:template name="body.attributes">
@@ -222,7 +221,7 @@
<xsl:if test="$query-parameters">&<xsl:value-of
select="$query-parameters[1]/text()"></xsl:value-of></xsl:if>
</xsl:variable>
<xsl:variable name="canvas-id" select="generate-id(.)"/>
- <xsl:variable name="swf-embed-params">{url: '<xsl:value-of
select="concat($fname, '?lzt=swf', $query-param)"/>', id: '<xsl:value-of
select="concat($canvas-id,'SWF')"/>', <xsl:value-of
select="$canvas-parameters"/>}</xsl:variable>
+ <xsl:variable name="swf-embed-params">{url: '<xsl:value-of
select="concat($fname, '?lzt=swf', $query-param)"/>', id: '<xsl:value-of
select="concat($canvas-id,'SWF')"/>', history: false, <xsl:value-of
select="$canvas-parameters"/>}</xsl:variable>
<xsl:variable name="dhtml-embed-params">{url: '<xsl:value-of
select="concat($fname, '?lzt=html&lzr=dhtml', $query-param)"/>', id:
'<xsl:value-of select="concat($canvas-id,'DHTML')"/>', <xsl:value-of
select="$canvas-parameters"/>}</xsl:variable>
<!-- To test examples in DHTML, uncomment the second script block
below.
If you don't want to see the SWF version as well, comment out the
@@ -355,7 +354,7 @@
</xsl:variable>
<xsl:message>Got canvas-width of <xsl:value-of select="$canvas-width"/>
and canvas-height of <xsl:value-of select="$canvas-height"/></xsl:message>
<xsl:variable name="canvas-id" select="generate-id(.)"/>
- <xsl:variable name="swf-embed-params">{url: '<xsl:value-of
select="concat($lzxdir, $fname, '?lzt=swf', $query-param)"/>', id:
'<xsl:value-of select="concat($canvas-id,'SWF')"/>', width: '<xsl:copy-of
select="$canvas-width"/>', height: '<xsl:copy-of
select="$canvas-height"/>'}</xsl:variable>
+ <xsl:variable name="swf-embed-params">{url: '<xsl:value-of
select="concat($lzxdir, $fname, '?lzt=swf', $query-param)"/>', id:
'<xsl:value-of select="concat($canvas-id,'SWF')"/>', width: '<xsl:copy-of
select="$canvas-width"/>', height: '<xsl:copy-of select="$canvas-height"/>',
history: false}</xsl:variable>
<xsl:variable name="dhtml-embed-params">{url: '<xsl:value-of
select="concat($lzxdir, $fname, '?lzt=html&lzr=dhtml', $query-param)"/>',
id: '<xsl:value-of select="concat($canvas-id,'DHTML')"/>', width: '<xsl:copy-of
select="$canvas-width"/>', height: '<xsl:copy-of
select="$canvas-height"/>'}</xsl:variable>
<div class="embedded-canvas">
_______________________________________________
Laszlo-checkins mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-checkins
