Author: ben
Date: 2008-01-01 16:52:17 -0800 (Tue, 01 Jan 2008)
New Revision: 7693
Modified:
openlaszlo/trunk/docs/src/xsl/common-html.xsl
Log:
Change 20080101-ben-w by [EMAIL PROTECTED] on 2008-01-01 16:43:46 PST
in /Users/ben/src/svn/openlaszlo/trunk
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: Fix misplaced comma in embedded examples
New Features:
Bugs Fixed:
Technical Reviewer: (pending)
QA Reviewer: max (pending)
Doc Reviewer: (pending)
Documentation:
Max reported a bug due to a stray comma:
http://labs.openlaszlo.org/trunk-nightly/docs/developers/tutorials/views-tutorial.html#
is failing now, due to a stray comma in the embedSWF calls, e.g.
Lz.swfEmbed({url: 'programs/views-tutorial-$1.lzx?lzt=swf', id:
'd0e6065SWF', history: false, width: 500,
height: 300,
});
This change moves around where we generate commas in the canvas parameters when
generating a live example. It now looks like this:
Lz.swfEmbed({url: 'programs/views-tutorial-$1.lzx?lzt=swf', id: 'd0e6061SWF',
history: false
, width: 500
, height: 300});
Release Notes:
Details:
Tests:
build the doc
inspect the source of tutorials/views-tutorial.html
note good comma-ness.
Modified: openlaszlo/trunk/docs/src/xsl/common-html.xsl
===================================================================
--- openlaszlo/trunk/docs/src/xsl/common-html.xsl 2008-01-02 00:47:05 UTC
(rev 7692)
+++ openlaszlo/trunk/docs/src/xsl/common-html.xsl 2008-01-02 00:52:17 UTC
(rev 7693)
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<!-- * X_LZ_COPYRIGHT_BEGIN ***************************************************
-* Copyright 2001-2007 Laszlo Systems, Inc. All Rights Reserved. *
+* Copyright 2001-2008 Laszlo Systems, Inc. All Rights Reserved. *
* Use is subject to license terms. *
* X_LZ_COPYRIGHT_END ****************************************************** -->
<!DOCTYPE xsl:stylesheet [
@@ -232,7 +232,7 @@
canvas widths.
The solution! Iterate over the result node set! -->
<xsl:for-each select="[EMAIL PROTECTED]'canvas']">
- <xsl:value-of select="."/>,
+ , <xsl:value-of select="."/> <!-- do a leading comma so that we don't
have a stray comma at the end -->
</xsl:for-each>
</xsl:variable>
@@ -245,8 +245,8 @@
<xsl:if test="$query-parameters">&<xsl:value-of
select="$query-parameters[1]/text()"></xsl:value-of></xsl:if>
</xsl:variable>
<xsl:variable name="canvas-id" select="generate-id(.)"/>
- <xsl:variable name="swf-embed-params">{url: '<xsl:value-of
select="concat($fname, '?lzt=swf', $query-param)"/>', id: '<xsl:value-of
select="concat($canvas-id,'SWF')"/>', history: false, <xsl:value-of
select="$canvas-parameters"/>}</xsl:variable>
- <xsl:variable name="dhtml-embed-params">{url: '<xsl:value-of
select="concat($fname, '?lzt=html&lzr=dhtml', $query-param)"/>', id:
'<xsl:value-of select="concat($canvas-id,'DHTML')"/>', <xsl:value-of
select="$canvas-parameters"/>}</xsl:variable>
+ <xsl:variable name="swf-embed-params">{url: '<xsl:value-of
select="concat($fname, '?lzt=swf', $query-param)"/>', id: '<xsl:value-of
select="concat($canvas-id,'SWF')"/>', history: false <xsl:value-of
select="$canvas-parameters"/>}</xsl:variable>
+ <xsl:variable name="dhtml-embed-params">{url: '<xsl:value-of
select="concat($fname, '?lzt=html&lzr=dhtml', $query-param)"/>', id:
'<xsl:value-of select="concat($canvas-id,'DHTML')"/>' <xsl:value-of
select="$canvas-parameters"/>}</xsl:variable>
<!-- To test examples in DHTML, uncomment the second script block
below.
If you don't want to see the SWF version as well, comment out the
first script block. -->
_______________________________________________
Laszlo-checkins mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-checkins
