Author: max
Date: 2008-02-15 00:09:54 -0800 (Fri, 15 Feb 2008)
New Revision: 8038
Modified:
openlaszlo/trunk/WEB-INF/lps/lfc/helpers/LzState.lzs
openlaszlo/trunk/WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js
openlaszlo/trunk/WEB-INF/lps/lfc/views/LzText.lzs
openlaszlo/trunk/lps/components/extensions/drawview.lzx
Log:
Change 20080214-maxcarlson-B by [EMAIL PROTECTED] on 2008-02-14 19:19:09 PST
in /Users/maxcarlson/openlaszlo/trunk
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: Fix states and constrained text in DHTML, fix drawview
New Features:
Bugs Fixed: LPP-1587 'ECMA4: Compile LZX declarations as JS declarations'
(partial)
Technical Reviewer: promanik
QA Reviewer: ptw
Doc Reviewer: (pending)
Documentation:
Release Notes:
Details: LzTextSprite.js - Don't store args.text from construct.
LzText.lzs - Default to '' in construct() when args.text instanceof
LzConstraintExpr || args.text instanceof LzInitExpr
LzState.lzs - More safety checking when unpacking args.
drawview.lzx - Don't use args.height/width/clip to init drawview.
Tests: drawview works again, no warnings under IE when reloading pages.
Constrained text works again.
Modified: openlaszlo/trunk/WEB-INF/lps/lfc/helpers/LzState.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/helpers/LzState.lzs 2008-02-15
04:53:11 UTC (rev 8037)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/helpers/LzState.lzs 2008-02-15
08:09:54 UTC (rev 8038)
@@ -193,7 +193,7 @@
// release any constraints you are about to override
var pia = parent._instanceAttrs;
for (var key in this.heldArgs) {
- if (key in pia && pia[key] instanceof LzConstraintExpr) {
+ if (pia && key in pia && pia[key] instanceof LzConstraintExpr) {
var constraintMethodName = pia[key].methodName;
parent.releaseConstraintMethod(constraintMethodName);
}
@@ -272,7 +272,7 @@
// NOTE: [2008-02-13 ptw] Keep in sync with LzNode#__LZresolveReferences
var pia = parent._instanceAttrs;
for (var key in this.heldArgs) {
- if (key in pia && pia[key] instanceof LzConstraintExpr) {
+ if (pia && key in pia && pia[key] instanceof LzConstraintExpr) {
var constraintMethodName = pia[key].methodName;
// TODO: [2008-02-06 ptw] the dependency computation needs
// to be a method also, probably stored in the
Modified: openlaszlo/trunk/WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js
2008-02-15 04:53:11 UTC (rev 8037)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js
2008-02-15 08:09:54 UTC (rev 8038)
@@ -41,7 +41,6 @@
this.setFontName(args.font);
this.setFontStyle(args.fontstyle);
this.setFontSize(args.fontsize);
- this.text = args.text;
}
// Should reflect CSS defaults in LzSprite.js
Modified: openlaszlo/trunk/WEB-INF/lps/lfc/views/LzText.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/views/LzText.lzs 2008-02-15 04:53:11 UTC
(rev 8037)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/views/LzText.lzs 2008-02-15 08:09:54 UTC
(rev 8038)
@@ -221,7 +221,7 @@
this.setMaxLength(args.maxlength);
}
- this.text = (!('text' in args) || args.text == null) ? "" : args.text;
+ this.text = (!('text' in args) || args.text == null || args.text
instanceof LzConstraintExpr || args.text instanceof LzInitExpr) ? "" :
args.text;
if(this.maxlength != null && this.text.length > this.maxlength){
this.text = this.text.substring(0, this.maxlength);
}
Modified: openlaszlo/trunk/lps/components/extensions/drawview.lzx
===================================================================
--- openlaszlo/trunk/lps/components/extensions/drawview.lzx 2008-02-15
04:53:11 UTC (rev 8037)
+++ openlaszlo/trunk/lps/components/extensions/drawview.lzx 2008-02-15
08:09:54 UTC (rev 8038)
@@ -1,6 +1,6 @@
<!---
- @copyright Copyright 2001-2007 Laszlo Systems, Inc. All Rights Reserved.
+ @copyright Copyright 2001-2008 Laszlo Systems, Inc. All Rights Reserved.
Use is subject to license terms.
@access public
@@ -564,9 +564,6 @@
var oncontext = LzDeclaredEvent;
function construct(parent,args) {
- args['width'] = args['width'] > -1 ? args.width : null;
- args['height'] = args['height'] > -1 ? args.height : null;
- args['clip'] = args['clip'] == true ? args.clip : null;
super.construct(parent, args);
this.context = this.getMCRef();
this.context.cacheAsBitmap = args['cachebitmap'] != null ?
args['cachebitmap'] : this.cachebitmap;
_______________________________________________
Laszlo-checkins mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-checkins
