Author: dda
Date: 2008-02-29 13:03:00 -0800 (Fri, 29 Feb 2008)
New Revision: 8140

Modified:
   openlaszlo/trunk/docs/src/xsl/js2doc2dbk/utilities.xsl
   openlaszlo/trunk/docs/src/xsl/lzx2js2doc.xsl
Log:
Change 20080229-dda-y by [EMAIL PROTECTED] on 2008-02-29 13:57:49 EST
    in /Users/clients/laszlo/src/svn/openlaszlo/trunk-doc2
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Doc: Set type defaults for attributes to 'expression'.

New Features:

Bugs Fixed: LPP-5528

Technical Reviewer: (pending)
QA Reviewer: (pending)
Doc Reviewer: lou (pending)

Documentation:

Release Notes:

Details:
    Note that a full ant build of doc may be required to see changes
    (I was not seeing changes until I did that).

    Any attributes of classes defined in lzx with no type information are
    now set to Tag type: expression JS type: any 

    'expression' simply means that a type was not selected.  Typically,
    this means that a type could have, and should be indicated.  For example,
    hbox.inset has no type, but it's initial value is 0, and if I were to say
    hbox.inset = 'hello', I would get strange results.  So really, its
    type should be indicated in the lzx file as 'Number'.  This change, then,
    provides compatibility for dealing with missing information, but
    there is still the underlying issue that the info is missing.

Tests:
   cd docs/src; ant clean; ant
   look at output, for example, hbox.



Modified: openlaszlo/trunk/docs/src/xsl/js2doc2dbk/utilities.xsl
===================================================================
--- openlaszlo/trunk/docs/src/xsl/js2doc2dbk/utilities.xsl      2008-02-29 
21:02:41 UTC (rev 8139)
+++ openlaszlo/trunk/docs/src/xsl/js2doc2dbk/utilities.xsl      2008-02-29 
21:03:00 UTC (rev 8140)
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <!-- * X_LZ_COPYRIGHT_BEGIN ***************************************************
-* Copyright 2007 Laszlo Systems, Inc.  All Rights Reserved.                   *
+* Copyright 2007-2008 Laszlo Systems, Inc.  All Rights Reserved.              *
 * Use is subject to license terms.                                            *
 * X_LZ_COPYRIGHT_END ****************************************************** -->
 <!DOCTYPE xsl:stylesheet [
@@ -97,7 +97,9 @@
           <xsl:text>Object</xsl:text>
         </xsl:when>
         <xsl:when test="$lzxtype = 'expression'">
-          <xsl:text>Object</xsl:text>
+          <!-- TODO [dda 2008-02-28] using 'Object' would be more correct,
+               but we are matching the 3.4 doc output for the moment -->
+          <xsl:text>any</xsl:text>
         </xsl:when>
         <xsl:when test="$lzxtype = 'boolean'">
           <!-- Either 'boolean' or 'Boolean' might be correct. Putting this 
rule in to document that we're making a choice -->
@@ -206,4 +208,4 @@
     </xsl:template>
     
     
-</xsl:stylesheet>
\ No newline at end of file
+</xsl:stylesheet>

Modified: openlaszlo/trunk/docs/src/xsl/lzx2js2doc.xsl
===================================================================
--- openlaszlo/trunk/docs/src/xsl/lzx2js2doc.xsl        2008-02-29 21:02:41 UTC 
(rev 8139)
+++ openlaszlo/trunk/docs/src/xsl/lzx2js2doc.xsl        2008-02-29 21:03:00 UTC 
(rev 8140)
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <!-- * X_LZ_COPYRIGHT_BEGIN ***************************************************
-* Copyright 2007 Laszlo Systems, Inc.  All Rights Reserved.                   *
+* Copyright 2007-2008 Laszlo Systems, Inc.  All Rights Reserved.              *
 * Use is subject to license terms.                                            *
 * X_LZ_COPYRIGHT_END ****************************************************** -->
 <!-- 
@@ -232,9 +232,14 @@
         <xsl:if test="@value">
           <tag name="lzxdefault"><text><xsl:value-of 
select="@value"/></text></tag>
         </xsl:if>
-        <xsl:if test="@type">
-          <tag name="lzxtype"><text><xsl:value-of select="@type"/></text></tag>
-        </xsl:if>
+        <xsl:choose>
+          <xsl:when test="@type">
+            <tag name="lzxtype"><text><xsl:value-of 
select="@type"/></text></tag>
+          </xsl:when>
+          <xsl:otherwise>
+            <tag name="lzxtype"><text>expression</text></tag>
+          </xsl:otherwise>
+        </xsl:choose>
         <xsl:if test="doc">
           <xsl:copy-of select="doc/*"/>
         </xsl:if>


_______________________________________________
Laszlo-checkins mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-checkins

Reply via email to