Author: ptw
Date: 2008-03-18 05:56:56 -0700 (Tue, 18 Mar 2008)
New Revision: 8305
Modified:
openlaszlo/trunk/WEB-INF/lps/lfc/controllers/LaszloAnimation.lzs
openlaszlo/trunk/WEB-INF/lps/lfc/controllers/LaszloLayout.lzs
openlaszlo/trunk/WEB-INF/lps/lfc/controllers/LzAnimatorGroup.lzs
openlaszlo/trunk/WEB-INF/lps/lfc/core/LzNode.lzs
openlaszlo/trunk/WEB-INF/lps/lfc/data/LzDataProvider.lzs
openlaszlo/trunk/WEB-INF/lps/lfc/data/LzDataRequest.lzs
openlaszlo/trunk/WEB-INF/lps/lfc/data/LzDatapath.lzs
openlaszlo/trunk/WEB-INF/lps/lfc/data/LzDatapointer.lzs
openlaszlo/trunk/WEB-INF/lps/lfc/data/LzDataset.lzs
openlaszlo/trunk/WEB-INF/lps/lfc/data/LzHTTPDatasource.lzs
openlaszlo/trunk/WEB-INF/lps/lfc/data/LzParam.lzs
openlaszlo/trunk/WEB-INF/lps/lfc/data/platform/swf/LzConnection.lzs
openlaszlo/trunk/WEB-INF/lps/lfc/data/platform/swf/LzConnectionDatasource.lzs
openlaszlo/trunk/WEB-INF/lps/lfc/helpers/LzCommand.lzs
openlaszlo/trunk/WEB-INF/lps/lfc/helpers/LzDataSelectionManager.lzs
openlaszlo/trunk/WEB-INF/lps/lfc/helpers/LzSelectionManager.lzs
openlaszlo/trunk/WEB-INF/lps/lfc/helpers/LzState.lzs
openlaszlo/trunk/WEB-INF/lps/lfc/kernel/LzLibraryCleanup.lzs
openlaszlo/trunk/WEB-INF/lps/lfc/kernel/dhtml/LzLibrary.js
openlaszlo/trunk/WEB-INF/lps/lfc/kernel/swf/LzLibrary.lzs
openlaszlo/trunk/WEB-INF/lps/lfc/kernel/swf9/LzLibrary.lzs
openlaszlo/trunk/WEB-INF/lps/lfc/views/LaszloCanvas.lzs
openlaszlo/trunk/WEB-INF/lps/lfc/views/LaszloView.lzs
openlaszlo/trunk/WEB-INF/lps/lfc/views/LzInputText.lzs
openlaszlo/trunk/WEB-INF/lps/lfc/views/LzScript.lzs
openlaszlo/trunk/WEB-INF/lps/lfc/views/LzText.lzs
Log:
Change 20080318-ptw-7 by [EMAIL PROTECTED] on 2008-03-18 08:52:33 EDT
in /Users/ptw/OpenLaszlo/ringding-clean
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: static var attributes is private
Bugs Fixed:
LPP-5619 et al. (partial)
Technical Reviewer: [EMAIL PROTECTED] (pending)
Doc Reviewer: [EMAIL PROTECTED] (pending)
Details:
Forgot to mark new class variable as private. Also remove some
debugging cruft left in LzNode.
Tests:
Inspection
Modified: openlaszlo/trunk/WEB-INF/lps/lfc/controllers/LaszloAnimation.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/controllers/LaszloAnimation.lzs
2008-03-18 12:00:08 UTC (rev 8304)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/controllers/LaszloAnimation.lzs
2008-03-18 12:56:56 UTC (rev 8305)
@@ -37,6 +37,7 @@
* @modifiers override
*/
static var tagname = 'animator';
+/** @access private */
static var attributes = new LzInheritedHash(LzAnimatorGroup.attributes);
var beginPoleDelta = .25;
Modified: openlaszlo/trunk/WEB-INF/lps/lfc/controllers/LaszloLayout.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/controllers/LaszloLayout.lzs
2008-03-18 12:00:08 UTC (rev 8304)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/controllers/LaszloLayout.lzs
2008-03-18 12:56:56 UTC (rev 8305)
@@ -65,6 +65,7 @@
* @modifiers override
*/
static var tagname = 'layout';
+/** @access private */
static var attributes = new LzInheritedHash(LzNode.attributes);
/**
Modified: openlaszlo/trunk/WEB-INF/lps/lfc/controllers/LzAnimatorGroup.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/controllers/LzAnimatorGroup.lzs
2008-03-18 12:00:08 UTC (rev 8304)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/controllers/LzAnimatorGroup.lzs
2008-03-18 12:56:56 UTC (rev 8305)
@@ -47,6 +47,7 @@
* @modifiers override
*/
static var tagname = 'animatorgroup';
+/** @access private */
static var attributes = new LzInheritedHash(LzNode.attributes);
/** The name of the attribute whose value is animated. This
Modified: openlaszlo/trunk/WEB-INF/lps/lfc/core/LzNode.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/core/LzNode.lzs 2008-03-18 12:00:08 UTC
(rev 8304)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/core/LzNode.lzs 2008-03-18 12:56:56 UTC
(rev 8305)
@@ -174,15 +174,8 @@
if (val is Function) {
Debug.debug("%s[%w] = %s", this, key, val);
}
- // TODO: [2008-03-17 ptw] The compiler needs
- // to filter out redeclarations that do not
- // specify an init value
- if ((val !== void 0) || (! (key in this))) {
- this.addProperty(key, val);
- delete iargs[key];
- } else if ($debug) {
- Debug.debug("Useless init arg: %w.%s = %w",
this, key, val);
- }
+ this.addProperty(key, val);
+ delete iargs[key];
}
}
}
Modified: openlaszlo/trunk/WEB-INF/lps/lfc/data/LzDataProvider.lzs
===================================================================
(Binary files differ)
Modified: openlaszlo/trunk/WEB-INF/lps/lfc/data/LzDataRequest.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/data/LzDataRequest.lzs 2008-03-18
12:00:08 UTC (rev 8304)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/data/LzDataRequest.lzs 2008-03-18
12:56:56 UTC (rev 8305)
@@ -26,6 +26,7 @@
* @modifiers override
*/
static var tagname = 'datarequest';
+/** @access private */
static var attributes = new LzInheritedHash(LzNode.attributes);
/* Status value constants */
Modified: openlaszlo/trunk/WEB-INF/lps/lfc/data/LzDatapath.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/data/LzDatapath.lzs 2008-03-18
12:00:08 UTC (rev 8304)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/data/LzDatapath.lzs 2008-03-18
12:56:56 UTC (rev 8305)
@@ -73,6 +73,7 @@
* @modifiers override
*/
static var tagname = 'datapath';
+/** @access private */
static var attributes = new LzInheritedHash(LzDatapointer.attributes);
/** By default, this is false for instances
Modified: openlaszlo/trunk/WEB-INF/lps/lfc/data/LzDatapointer.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/data/LzDatapointer.lzs 2008-03-18
12:00:08 UTC (rev 8304)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/data/LzDatapointer.lzs 2008-03-18
12:56:56 UTC (rev 8305)
@@ -82,6 +82,7 @@
// static var attributes = new LzInheritedHash(LzNode.attributes);
// [2006-07-25 pbr] This clears out what is defined in LzNode. Is this
// ok?
+/** @access private */
static var attributes = {ignoreplacement: true};
/** @access private */
Modified: openlaszlo/trunk/WEB-INF/lps/lfc/data/LzDataset.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/data/LzDataset.lzs 2008-03-18 12:00:08 UTC
(rev 8304)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/data/LzDataset.lzs 2008-03-18 12:56:56 UTC
(rev 8305)
@@ -96,6 +96,7 @@
* @modifiers override
*/
static var tagname = 'dataset';
+/** @access private */
static var attributes = new LzInheritedHash(LzNode.attributes);
var dataprovider = defaultdataprovider;
Modified: openlaszlo/trunk/WEB-INF/lps/lfc/data/LzHTTPDatasource.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/data/LzHTTPDatasource.lzs 2008-03-18
12:00:08 UTC (rev 8304)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/data/LzHTTPDatasource.lzs 2008-03-18
12:56:56 UTC (rev 8305)
@@ -29,6 +29,7 @@
* @modifiers override
*/
static var tagname = 'datasource';
+/** @access private */
static var attributes = new LzInheritedHash(LzDatasource.attributes);
var reqtype = "GET";
Modified: openlaszlo/trunk/WEB-INF/lps/lfc/data/LzParam.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/data/LzParam.lzs 2008-03-18 12:00:08 UTC
(rev 8304)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/data/LzParam.lzs 2008-03-18 12:56:56 UTC
(rev 8305)
@@ -42,6 +42,7 @@
* @modifiers override
*/
static var tagname = 'params';
+/** @access private */
static var attributes = new LzInheritedHash(LzNode.attributes);
// FIXME: [2008-03-12 ptw] WTF is this supposed to be doing?
Modified: openlaszlo/trunk/WEB-INF/lps/lfc/data/platform/swf/LzConnection.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/data/platform/swf/LzConnection.lzs
2008-03-18 12:00:08 UTC (rev 8304)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/data/platform/swf/LzConnection.lzs
2008-03-18 12:56:56 UTC (rev 8305)
@@ -177,6 +177,7 @@
* @modifiers override
*/
static var tagname = 'connection';
+/** @access private */
static var attributes = new LzInheritedHash(LzHTTPDatasource.attributes);
/**
Modified:
openlaszlo/trunk/WEB-INF/lps/lfc/data/platform/swf/LzConnectionDatasource.lzs
===================================================================
---
openlaszlo/trunk/WEB-INF/lps/lfc/data/platform/swf/LzConnectionDatasource.lzs
2008-03-18 12:00:08 UTC (rev 8304)
+++
openlaszlo/trunk/WEB-INF/lps/lfc/data/platform/swf/LzConnectionDatasource.lzs
2008-03-18 12:56:56 UTC (rev 8305)
@@ -125,6 +125,7 @@
* @modifiers override
*/
static var tagname = 'connectiondatasource';
+/** @access private */
static var attributes = new LzInheritedHash(LzDatasource.attributes);
/**
Modified: openlaszlo/trunk/WEB-INF/lps/lfc/helpers/LzCommand.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/helpers/LzCommand.lzs 2008-03-18
12:00:08 UTC (rev 8304)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/helpers/LzCommand.lzs 2008-03-18
12:56:56 UTC (rev 8305)
@@ -36,6 +36,7 @@
* @modifiers override
*/
static var tagname = 'command';
+/** @access private */
static var attributes = new LzInheritedHash(LzNode.attributes);
/**
Modified: openlaszlo/trunk/WEB-INF/lps/lfc/helpers/LzDataSelectionManager.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/helpers/LzDataSelectionManager.lzs
2008-03-18 12:00:08 UTC (rev 8304)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/helpers/LzDataSelectionManager.lzs
2008-03-18 12:56:56 UTC (rev 8305)
@@ -72,6 +72,7 @@
* @modifiers override
*/
static var tagname = 'dataselectionmanager';
+/** @access private */
static var attributes = new LzInheritedHash(LzSelectionManager.attributes);
/**
Modified: openlaszlo/trunk/WEB-INF/lps/lfc/helpers/LzSelectionManager.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/helpers/LzSelectionManager.lzs
2008-03-18 12:00:08 UTC (rev 8304)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/helpers/LzSelectionManager.lzs
2008-03-18 12:56:56 UTC (rev 8305)
@@ -92,6 +92,7 @@
* @modifiers override
*/
static var tagname = 'selectionmanager';
+/** @access private */
static var attributes = new LzInheritedHash(LzNode.attributes);
/** The name of the method to call on an object
Modified: openlaszlo/trunk/WEB-INF/lps/lfc/helpers/LzState.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/helpers/LzState.lzs 2008-03-18
12:00:08 UTC (rev 8304)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/helpers/LzState.lzs 2008-03-18
12:56:56 UTC (rev 8305)
@@ -78,6 +78,7 @@
* @modifiers override
*/
static var tagname = 'state';
+/** @access private */
static var attributes = new LzInheritedHash(LzNode.attributes);
/** Sent when the state is applied.
Modified: openlaszlo/trunk/WEB-INF/lps/lfc/kernel/LzLibraryCleanup.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/kernel/LzLibraryCleanup.lzs
2008-03-18 12:00:08 UTC (rev 8304)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/kernel/LzLibraryCleanup.lzs
2008-03-18 12:56:56 UTC (rev 8305)
@@ -17,6 +17,7 @@
* @modifiers override
*/
static var tagname = '__libraryloadercomplete';
+/** @access private */
static var attributes = new LzInheritedHash(LzNode.attributes);
function LzLibraryCleanup ( owner , args ) {
Modified: openlaszlo/trunk/WEB-INF/lps/lfc/kernel/dhtml/LzLibrary.js
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/kernel/dhtml/LzLibrary.js 2008-03-18
12:00:08 UTC (rev 8304)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/kernel/dhtml/LzLibrary.js 2008-03-18
12:56:56 UTC (rev 8305)
@@ -18,6 +18,7 @@
* @modifiers override
*/
static var tagname = 'import';
+/** @access private */
static var attributes = new LzInheritedHash(LzNode.attributes);
/** @access private */
Modified: openlaszlo/trunk/WEB-INF/lps/lfc/kernel/swf/LzLibrary.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/kernel/swf/LzLibrary.lzs 2008-03-18
12:00:08 UTC (rev 8304)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/kernel/swf/LzLibrary.lzs 2008-03-18
12:56:56 UTC (rev 8305)
@@ -18,6 +18,7 @@
* @modifiers override
*/
static var tagname = 'import';
+/** @access private */
static var attributes = new LzInheritedHash(LzNode.attributes);
/** @access private */
Modified: openlaszlo/trunk/WEB-INF/lps/lfc/kernel/swf9/LzLibrary.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/kernel/swf9/LzLibrary.lzs 2008-03-18
12:00:08 UTC (rev 8304)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/kernel/swf9/LzLibrary.lzs 2008-03-18
12:56:56 UTC (rev 8305)
@@ -18,6 +18,7 @@
* @modifiers override
*/
static var tagname = 'import';
+/** @access private */
static var attributes = new LzInheritedHash(LzNode.attributes);
/**
Modified: openlaszlo/trunk/WEB-INF/lps/lfc/views/LaszloCanvas.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/views/LaszloCanvas.lzs 2008-03-18
12:00:08 UTC (rev 8304)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/views/LaszloCanvas.lzs 2008-03-18
12:56:56 UTC (rev 8305)
@@ -60,6 +60,7 @@
* @modifiers override
*/
static var tagname = 'canvas';
+/** @access private */
static var attributes = new LzInheritedHash(LzView.attributes);
function LzCanvas ( args ) {
Modified: openlaszlo/trunk/WEB-INF/lps/lfc/views/LaszloView.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/views/LaszloView.lzs 2008-03-18
12:00:08 UTC (rev 8304)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/views/LaszloView.lzs 2008-03-18
12:56:56 UTC (rev 8305)
@@ -62,6 +62,7 @@
* @modifiers override
*/
static var tagname = 'view';
+/** @access private */
static var attributes = new LzInheritedHash(LzNode.attributes);
// We add some more kludges to those in LzNode. See #construct
// where we override the LzNode setting
Modified: openlaszlo/trunk/WEB-INF/lps/lfc/views/LzInputText.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/views/LzInputText.lzs 2008-03-18
12:00:08 UTC (rev 8304)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/views/LzInputText.lzs 2008-03-18
12:56:56 UTC (rev 8305)
@@ -76,6 +76,7 @@
* @modifiers override
*/
static var tagname = 'inputtext';
+/** @access private */
static var attributes = new LzInheritedHash(LzText.attributes);
LzNode.mergeAttributes({selectable: true, enabled: true},
LzInputText.attributes);
Modified: openlaszlo/trunk/WEB-INF/lps/lfc/views/LzScript.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/views/LzScript.lzs 2008-03-18 12:00:08 UTC
(rev 8304)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/views/LzScript.lzs 2008-03-18 12:56:56 UTC
(rev 8305)
@@ -67,6 +67,7 @@
* @modifiers override
*/
static var tagname = 'script';
+/** @access private */
static var attributes = new LzInheritedHash(LzNode.attributes);
function LzScript ( parent, args ) {
Modified: openlaszlo/trunk/WEB-INF/lps/lfc/views/LzText.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/views/LzText.lzs 2008-03-18 12:00:08 UTC
(rev 8304)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/views/LzText.lzs 2008-03-18 12:56:56 UTC
(rev 8305)
@@ -77,6 +77,7 @@
* @modifiers override
*/
static var tagname = 'text';
+/** @access private */
static var attributes = new LzInheritedHash(LzView.attributes);
/** Sent whenever the text in the field changes.
_______________________________________________
Laszlo-checkins mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-checkins
