Author: max
Date: 2008-03-21 16:28:24 -0700 (Fri, 21 Mar 2008)
New Revision: 8344
Modified:
openlaszlo/trunk/WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
openlaszlo/trunk/test/smoke/regression.lzl
openlaszlo/trunk/test/smoke/smokecheck.lzx
Log:
Change 20080320-maxcarlson-u by [EMAIL PROTECTED] on 2008-03-20 19:00:50 PDT
in /Users/maxcarlson/openlaszlo/trunk
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: Fix bug-2125 regression test
New Features:
Bugs Fixed: LPP-5610 - bug-2125 regression test is broken
Technical Reviewer: ptw
QA Reviewer: promanik
Doc Reviewer: (pending)
Documentation:
Release Notes:
Details: regression.lzl - Updated bug-2125 to deal with asynchronous loading.
smoke.lzx - Uncomment bug-2125
LzSprite.js - Remove unused source attribute, use resource instead so
__imgonload sends the right value.
Tests: trunk/test/smoke/smokecheck.lzx and
trunk/test/smoke/smokecheck.lzx?lzr=dhtml. Also see updated testcase in
LPP-5610.
Modified: openlaszlo/trunk/WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js 2008-03-21
20:19:31 UTC (rev 8343)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js 2008-03-21
23:28:24 UTC (rev 8344)
@@ -395,7 +395,6 @@
LzSprite.prototype.frames = null;
LzSprite.prototype.blankimage = lzOptions.ServerRoot +
'/lps/includes/blank.gif';
LzSprite.prototype.resource = null;
-LzSprite.prototype.source = null;
LzSprite.prototype.visible = null;
LzSprite.prototype.text = null;
LzSprite.prototype.clip = null;
@@ -463,7 +462,6 @@
if ( r.indexOf('http:') == 0 || r.indexOf('https:') == 0){
this.skiponload = false;
this.setSource( r );
- this.resource = r;
return;
}
@@ -522,7 +520,7 @@
//Debug.info('setSource ' + url)
this.loading = true;
- this.source = url;
+ this.resource = url;
if (! this.__ImgPool) {
this.__ImgPool = new LzPool(LzSprite.prototype.__getImage,
LzSprite.prototype.__gotImage, LzSprite.prototype.__destroyImage, this);
}
Modified: openlaszlo/trunk/test/smoke/regression.lzl
===================================================================
--- openlaszlo/trunk/test/smoke/regression.lzl 2008-03-21 20:19:31 UTC (rev
8343)
+++ openlaszlo/trunk/test/smoke/regression.lzl 2008-03-21 23:28:24 UTC (rev
8344)
@@ -824,10 +824,15 @@
</class>
<class name="bug_2125" extends="TestCase">
- <view name="lview"/>
+ <view name="lview">
+ <handler name="onload">
+ parent.assertNotNull(this['resource'], 'resource
attribute undefined!');
+ parent.assertEquals(this['resource'],
'http:../resources/gif/logo.gif');
+ </handler>
+ </view>
+
<method name="testSrc">
- lview.setSource('http:../resources/swf/logo.swf')
- assertNotUndefined(lview['resource'], 'Source
attribute undefined!')
+ lview.setSource('http:../resources/gif/logo.gif')
</method>
</class>
Modified: openlaszlo/trunk/test/smoke/smokecheck.lzx
===================================================================
--- openlaszlo/trunk/test/smoke/smokecheck.lzx 2008-03-21 20:19:31 UTC (rev
8343)
+++ openlaszlo/trunk/test/smoke/smokecheck.lzx 2008-03-21 23:28:24 UTC (rev
8344)
@@ -119,7 +119,7 @@
<bug_1899/>
<bug_2029/>
<bug_2113/>
-<!-- Broken: LPP-5160 <bug_2125/> -->
+ <bug_2125/>
<bug_2131/>
<bug_2223/>
<bug_2225/>
_______________________________________________
Laszlo-checkins mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-checkins
