[Laszlo-dev] Re: For Review: Change 35233 Summary:Add a few unit tests for LzNode.

[Jim Grandy]

On Nov 29, 2005, at 12:33 PM, P T Withington wrote:

Approved! First in a series of many steps to have a complete LFC API test suite.

Thanks. I'll update in response to your comments below.

I have a couple of questions you may or may not want to address:

It's not clear to me that LzNode.subnodes is guaranteed to be in any particular order, but in lzunit-node.lzx you are testing that.

Really? Shouldn't lexical order map into subnodes order? Otherwise, how would things like layout or list work predictably?

(Classes obviously make it more complex than just lexical order, but I think we should still be able to formalize.)

Line 65 of lzunit-node-initsequence seems confused:

        var testname = testname = this.name;

I'll fix this; thanks.

Do you need a more complex structure to test the difference between normal and immediate? They seem to have the same result.

I'm happy to take suggestions. The description of this initstage doesn't distinguish itself enough for me, so I'm not clear what the difference should be.

In lzunit-node-replication.lzx you say:

// doesn't work until LzNode.searchSubnodes is fixed to search subnodes instead of subviews.

but the test itself is not commented out?

My mistake -- I have that bug fixed in my sources. I'll comment it out in the version I check in.

On 28 Nov 2005, at 20:05, Jim Grandy wrote:

Change 35233 by [EMAIL PROTECTED] on 2005/11/28 17:02:32 *pending*

        Summary:Add a few unit tests for LzNode.
        
        Technical Reviewer: ptw (pending)
        QA Reviewer: frisco (pending)
        Doc Reviewer:
        

        
Affected files ...

... //depot/lps-dev/test/lfc/lzunit-node-initsequence.lzx#1 add
... //depot/lps-dev/test/lfc/lzunit-node-replication.lzx#1 add
... //depot/lps-dev/test/lfc/lzunit-node.lzx#1 add
... //depot/lps-dev/test/lzunit/testpaths.txt#2 edit

<changeset-35233.zip>

Details: I wrote these in part to understand how initialization and initstage works

smime.p7s
Description: S/MIME cryptographic signature

_______________________________________________
Laszlo-dev mailing list
Laszlo-dev@openlaszlo.org
http://www.openlaszlo.org/mailman/listinfo/laszlo-dev