A few comments. Some of these are design-related but didn't jump out at me when I read your proposal; sorry.

- it's confusing that the contextmenu gets an onselect event when opening. I guess this is the event Flash sends, but it doesn't sound right. Sarah agrees the Flash choice was wrong. Can we use oncontextmenu instead?

- I see setDelegate and setCallback for LzContextMenuItem, but not for LzContextMenu. The two should both have setters if either has them.

- Should the method be called "setCallback"? What if additional events were added in the future? How about "setOnSelect" for menu items and "setOnContextMenu" for menus.

- Same for "setDelegate". "setOnSelectDelegate" and "setOnContextMenuDelegate"?

- I assume you've thought through how these callbacks could be used to implement the familiar event notation in the (to-be-written) declarative interface. I don't know how events are implemented so I can't see that myself.

- The descriptions of many of the methods in LzContextMenu.as are wrong. For example, setVisible says, "Sets the function which will be called when the menu item is selected".

- There should be class descriptions as well for the reference guide, and a DEFINE OBJECT for LzContextMenuItem.

jim

On Dec 5, 2005, at 11:17 AM, Henry Minsky wrote:



--
Henry Minsky
Software Architect
[EMAIL PROTECTED]

<changeset-35131.zip>

Attachment: smime.p7s
Description: S/MIME cryptographic signature

_______________________________________________
Laszlo-dev mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-dev

Reply via email to