I think the event should be something like [onopen] or [oncontextmenuopen] (bleh.) to more closely match with the on<verb> syntax of [onclick], [oninit], [onconstruct].
I like using a typographical convention to wrap event names in [].
-e
On Mon, Dec 5, 2005 at 12:29 PM, Henry Minsky wrote:
On 12/5/05, Jim Grandy < [EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]> > wrote: A few comments. Some of these are design-related but didn't jump out at me when I read your proposal; sorry.
- it's confusing that the contextmenu gets an onselect event when opening. I guess this is the event Flash sends, but it doesn't sound right. Sarah agrees the Flash choice was wrong. Can we use oncontextmenu instead?
- I see setDelegate and setCallback for LzContextMenuItem, but not for LzContextMenu. The two should both have setters if either has them.
- Should the method be called "setCallback"? What if additional events were added in the future? How about "setOnSelect" for menu items and "setOnContextMenu" for menus.
I ought to check and see if there is any precedent in any of the other APIs for how
to name the callback setting function..
- Same for "setDelegate". "setOnSelectDelegate" and "setOnContextMenuDelegate"?
- I assume you've thought through how these callbacks could be used to implement the familiar event notation in the (to-be-written) declarative interface. I don't know how events are implemented so I can't see that myself.
I came to the conclusion that the declarative API will be implemented using
a different set of classes ,which just call these APIs internally, so it should be no problem.
- The descriptions of many of the methods in LzContextMenu.as are wrong. For example, setVisible says, "Sets the function which will be called when the menu item is selected".
oops.
- There should be class descriptions as well for the reference guide, and a DEFINE OBJECT for LzContextMenuItem.
ok
jim
On Dec 5, 2005, at 11:17 AM, Henry Minsky wrote:
--
Henry Minsky
Software Architect
[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>
<changeset-35131.zip>
--
Henry Minsky
Software Architect
[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>
------------------------------
_______________________________________________
Laszlo-dev mailing list
---=---===-------
Elliot Winard
Software Engineer
Laszlo Studios
---=---===-------
--
Sent with LaszloMail
_______________________________________________ Laszlo-dev mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-dev
