I understood what you meant by removing warnings. My point was that
your comment seems to imply that the two lines following should be
removed once all "code that is causing warnings" is removed from the
LFC. In my opinion, these particular lines are of use. I don't think
that they will be redundant, even when the LFC no longer has code that
causes warnings. Sorry if my previous email was not clear.
-Jason
P T Withington wrote:
> Oh, when we say 'removing warnings', we mean 'fixing code that is
> causing warnings', not 'taking the warning feature away'.
>
> [Background: currently warnings are turned off in the core code. We
> would like to enable them, so it will be easier to develop and debug
> the core. The task we have is to bring the core code up to snuff so
> that when we enable warnings none are signalled.]
>
> On 2006-05-19, at 17:08 EDT, Jason Stafford wrote:
>
>> Tucker,
>>
>> In the code for LzNode.makeChild is a comment:
>>
>> // TODO: [2005-03-24 ptw] Remove this if we ever enable
>> // warnings in the LFC as this will be redundant
>> if ($debug) {
>> if (! x) { Debug.error('Class %s used before defined', e.name); }
>> }
>>
>> Since you are in the process of enabling warnings in the LFC, I would
>> request that you ignore this comment and not remove the warning that
>> follows it.
>>
>> It just saved me considerable headache in a case where I was creating
>> objects on the fly, and used:
>> {attrs: {text: 'One'}, name: menuitem}
>> as an array element to pass to createChildren, instead of the correct
>> (note the quotes around menuitem):
>> {attrs: {text: 'One'}, name: 'menuitem'}
>>
>> The warning was a little obscure, but at least it got me pointed to
>> the fact that my name was not correct.
>>
>> If you agree, could just remove this comment.
>>
>> Thanks,
>>
>> Jason Stafford
>>
>> --Jason Stafford
>> Principal Developer
>> Inspiration Software, Inc.
>> The leader in visual thinking & learning
>>
>> Introducing INSPIRATION(r) 8, the essential tool to visualize, think,
>> organize and learn. Students use Inspiration to plan, research and
>> complete projects successfully. Learn more at www.inspiration.com.
>> 503-297-3004 Extension 119
>> 503-297-4676 (Fax)
>> 9400 SW Beaverton-Hillsdale Highway
>> Suite 300
>> Beaverton, OR 97005-3300
>>
>
--
Jason Stafford
Principal Developer
Inspiration Software, Inc.
The leader in visual thinking & learning
Introducing INSPIRATION(r) 8, the essential tool to visualize, think,
organize and learn. Students use Inspiration to plan, research and
complete projects successfully. Learn more at www.inspiration.com.
503-297-3004 Extension 119
503-297-4676 (Fax)
9400 SW Beaverton-Hillsdale Highway
Suite 300
Beaverton, OR 97005-3300
_______________________________________________
Laszlo-dev mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-dev
