Hi Tucker,
I've compiled a list of questions for you. I've finished the files in the
data directory (except for the Traits files). Hopefully this list will
avoid two rounds of reviews.
1. In LzDataset.lzs and other places is this definition,
prototype.nodeType = LzDataNode.DOCUMENT_NODE;
nodeType is defined in both derived trait classes. Can this be just
'nodeType = ...'
2. In LzDataset.lzs I made anonDatasourceNum a static. Can you verify that
this is ok?
3. In LzDataset.lzs is LzHttpDatasetPool. I haven't converted it because it
looks like a singleton, and I can't find a reference to it.
4. In LzDatapointer.lzs is this,
defaultattrs = {};
Is it ok to reset the values set in LzNode?
5. In LzDataText.lzs I had to specify the class derives from Instance,
because lzpix doesn't start properly if I don't.
class LzDataText extends LzDataNode, Instance {
6. In LzDataText.lzs, is this line necessary?
prototype.setAttribute = LzNode.prototype.setAttribute;
7. Like (4), in LzDataText.lzs is,
setters = {};
Is this ok?
8. In LzReplicationManager.lzs, I specified a function as static. Is this ok?
static function __LZemptyFuntion ( ){
9. Should I convert LzParsedPath.lzs? One of the functions, trim, is used
by other files. If I make it a class, do I make this static, and call it
via, 'LzParsedPath.trim', instead of the current 'LzParsedPath.prototype.trim'?
Thanks!
Phil
_______________________________________________
Laszlo-dev mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-dev
