This does indeed make the test pass. Thanks, tucker. On Sep 4, 2006, at 2:08 PM, P T Withington wrote:
> Yes, the test passes (that's why I listed it under 'Tests:', but > maybe I should have said that it passed). > > I'll check this in so you guys can play with it. If you decide we > need to either de-optimize it by splitting the $style function for > each attribute, or optimize it by caching constant $style's open a > new bug (but I'd really prefer that we know that it is a hot-spot > before we invest in an optimization). > > On 2006-09-04, at 14:08 EDT, Adam Wolff wrote: > >> This looks good. Does this test pass now? >> http://localhost:8080/coal/test/style/constraints/constraint-test.lzx >> >> If so, consider this reviewed. >> >> A >> >> >> >> On Sep 4, P T Withington wrote: >> >>> Change change.ptpIrl8ZB.txt by [EMAIL PROTECTED] >>> /Users/ptw/pending-changes/ on 2006-09-04 12:41:24 EDT >>> >>> Summary: Make $styles inherit correctly from superclasses >>> >>> Bugs Fixed: >>> LPP-2606 $styles does not inherit from superclass >>> >>> Technical Reviewer: adam (pending) >>> QA Reviewer: ben (pending) >>> Doc Reviewer: n/a >>> >>> Details: >>> Define a default $styles method that returns null. The >>> compiler-generated $styles method calls super.$styles and if >>> it is >>> a map, adds to that map, otherwise, creates and returns a new >>> map. >>> >>> Change LzNode's initialize method to correctly invoke the $styles >>> method, not the $styles function in the arglist. >>> >>> Tests: >>> test/style/constraints/constraint-test.lzx >>> >>> Files: >>> M lps/lfc/core/LzNode.as >>> M lps/server/src/org/openlaszlo/compiler/NodeModel.java >>> >> >> _______________________________________________ >> Laszlo-dev mailing list >> [email protected] >> http://www.openlaszlo.org/mailman/listinfo/laszlo-dev > > > _______________________________________________ > Laszlo-dev mailing list > [email protected] > http://www.openlaszlo.org/mailman/listinfo/laszlo-dev _______________________________________________ Laszlo-dev mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-dev
