I had trouble with svn-makechangepackage, it kept barfing on that one test file, even though the file is there.

$ svn-makechangepackage
WEB-INF\\lps\\schema\\lzx.rnc
WEB-INF\\lps\\lfc\\data\\LzReplicationManager.as
WEB-INF\\lps\\server\\src\\org\\openlaszlo\\compiler\\CanvasCompiler.java
WEB-INF\\lps\\server\\src\\org\\openlaszlo\\compiler\\SWFWriter.java
WEB-INF\\lps\\server\\src\\org\\openlaszlo\\compiler\\Canvas.java
WEB-INF\\lps\\server\\src\\org\\openlaszlo\\compiler\\FontInfo.java
tar: test\\style\typography\typography-test.lzx: Cannot stat: No such file or directory
tar: Error exit delayed from previous errors
change.iXrpK5908.txt
apply.sh
filelist.txt
difffile
files.tar
Created /home/hqm/src/svn/openlaszlo/trunk/patch.hqm.5948.tgz



On 9/20/06, Benjamin Shine <[EMAIL PROTECTED]> wrote:
Looks good -- that's a lot of swf5 specific stuff in there. Approved. 

files.tar didn't work right for me, though. It treated the backslash in the WEB-INF\ filenames as just a character in the filename. I applied the patch instead, and that worked. If you extract files.tar, do you get the correct directory structure, or just flat but long filenames? 


On Sep 19, 2006, at 7:08 PM, Henry Minsky wrote:

Here is a patch for review


Change change.iXrpK5908.txt by [EMAIL PROTECTED] /home/hqm/src/svn/openlaszlo/trunk/ on 2006-09-19 21:56:06 EDT

Summary: fix for 2639, fontstyle , fontsize attribute barfs on constraints

New Features:

Bugs Fixed:
LPP-2639


Technical Reviewer: ben
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:

  FontInfo changes

  + Don't try to parse/normalize a style name which is a constraint pattern

  + Return null when coercing an undefined style to a string, don't throw an error

Also took this opportunity to remove last vestiges of Flash 5 code paths.   

Tests:

styles/typography test from bug report, amazon, styles example, misc tests in test/text
for fonts defaulting


Files:
M      WEB-INF\lps\schema\lzx.rnc
M      WEB-INF\lps\lfc\data\LzReplicationManager.as
M      WEB-INF\lps\server\src\org\openlaszlo\compiler\CanvasCompiler.java
M      WEB-INF\lps\server\src\org\openlaszlo\compiler\SWFWriter.java
M      WEB-INF\lps\server\src\org\openlaszlo\compiler\Canvas.java
M      WEB-INF\lps\server\src\org\openlaszlo\compiler\FontInfo.java
M      test/style/typography/typography-test.lzx



On 9/14/06, Benjamin Shine <[EMAIL PROTECTED]> wrote:

Gregor wants fontstyle="$style{'mystyle'} to work. Tucker, can you
whip out a fix for LPP-2639, about which you said, "This is surely
just a bogus optimization in the tag compiler that is expecting
fontstyle and fontsize to be constant strings." Or is this a Henry
thing?

We already have a test case,
http://localhost:8080/trunk-svnx/test/style/typography/typography-
test.lzx
just uncomment gt7 to manifest the error.

-ben

_______________________________________________
Laszlo-dev mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-dev



--
Henry Minsky
Software Architect
[EMAIL PROTECTED]

<patch.hqm.3928.tgz>




--
Henry Minsky
Software Architect
[EMAIL PROTECTED]

_______________________________________________
Laszlo-dev mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-dev

Reply via email to