Approved, if you change initTextProperties() -> __initTextProperties() - it should prolly be a 'private' method.

-Max

Henry Minsky wrote:
http://svn.openlaszlo.org/openlaszlo/patches/20061026-hqm-d.tar
Change 20061026-hqm-d by [EMAIL PROTECTED] on 2006-10-26 01:03:10 PST
    in /cygdrive/c/users/hqm/openlaszlo/branches/legals

Summary: fix text bugs

New Features:

Bugs Fixed:

Technical Reviewer: max (pending)
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:

The constructor for LzText needs to pass font information to the text sprite, but it cannot compute font inheritance until after super.construct() has run, at which point it is too late to pass that info
to the __makeSprite constructor.

So I split out the text sprite init into two phases, the second phase is now called initTextProperties, and is
called from LzText.construct. This is a new API change the LzTextSprite.





Tests:

calendar in dhtml/swf, amazon in swf, test/lztest/lztest-textheight.lzx

Files:
M      test/lztest/smoketest.txt
A      test/lztest/lztest-textheight.lzx
M      WEB-INF/lps/lfc/kernel/swf/LzTextSprite.as
M      WEB-INF/lps/lfc/kernel/swf/LzInputTextSprite.as
M      WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js
M      WEB-INF/lps/lfc/views/LzInputText.lzs
M      WEB-INF/lps/lfc/views/LzText.lzs



--
Henry Minsky
Software Architect
[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>

Reply via email to