On 2006-10-30, at 14:32 EST, Philip Romanik wrote:
Hi Tucker,
How do I interpret this debug message in Class.lzx:
DEBUG: Shim LzDataText.setAttribute [2]
I'm tracking down issues with grid and want to know if I need to
worry about this message.
It means that LzDataText would break if we removed the last bit of
the class shim. Thanks for spotting this. We need to fix the
declaration of LzDataText. This is the change that needs to be
made. Do you want to just take it, or shall I make a patch for you
to review? (Basically, LzDataText was trying to create its own
setters mechanism, rather than using LzMiniNode, whose only purpose
is to do just that, but in a way that does not require smashing
prototypes.)
Index: LzDataText.lzs
===================================================================
--- LzDataText.lzs (revision 2292)
+++ LzDataText.lzs (working copy)
@@ -14,7 +14,7 @@
//
========================================================================
======
// FIXME: [2006-07-26] (LPP-2412) The Instance reference is required
for lzpix
// to run.
-class LzDataText inherits LzDataNode {
+class LzDataText extends LzMiniNode inherits LzDataNode {
function initialize ( text ){
super.initialize(text);
@@ -33,13 +33,6 @@
//and can raise a DOMException object on retrieval.
var nodeType = LzDataNode.TEXT_NODE;
-prototype.setAttribute = LzNode.prototype.setAttribute;
-// TODO: [2006-05-19 ptw] Rationalize this. Perhaps
-// setters/getters/defaultattrs should be in a mixin?
-// Because this does not inherit from Node, kludge for now
-
-var setters = {};
-
setters.data = "setData";
//@field String data: The data held by this node.
