On Oct 31, 2006, at 7:50 AM, Henry Minsky wrote:
On 10/31/06, P T Withington <[EMAIL PROTECTED]> wrote: [cc-ing Jim Grandy -- see below]
Comments:
1. We gotta get your line-endings straightened out. The new files
you added all have DOS line-ends, and the old files have UNIX line-ends.
Argh, I don't know what the story is here anymore. I wish I could get subversion to not translate to native
line endings anymore. Can anyone tell me if there is a global flag I can set on my client to
leave things in unix style eols? Altenrately perhaps I can get my emacs to convert to unix eols every time I touch
a file.
Isn't that the point of "native", that you'll have DOS line-ends on your machine, and then we'll all see Unix line-ends on ours? Tucker, you are looking at the files as they exist on Henry's machine, so perhaps there's no issue here.
3. Since you are visiting all these files, doing if/else-if, should
you add a final else with a `Debug.error('Unsupported runtime %s',
$runtime)`? Or should we revisit our compile-time conditional
construct? Perhaps we should be using something like Lisp ECASE?
That's a good idea.
Yes, please. Along that line, there are places where you changed `if ($dhtml) {}
else` with `if ($as2)`. I'm wondering about that, since the former
way essentially documented that we intended no support for $dhtml
here. So again, I would change this to and if/else-if, listing every
runtime that has been thought about, and a final else clause that
gives an error.
Yeah that would be better for maintainability.
Yes, please. [Jim Grandy] 4. Since you are visiting all the $runtime places,
should you change orbit to j2me?
Yes, please. 5. I don't feel qualified to review the svg response templates. Is
there anyone out there who does?
They're really just placeholders, to get something in which approximates a
working page. I just wanted to leave things in a state where you can say
foo.lzx?lzr=svg, and have something come up. Eventually the html-response.xslt will probably need to get cloned or the svg stuff merged into it.
Finally, approved if you address the comments. This is great stuff!
On 2006-10-31, at 00:53 EST, Henry Minsky wrote:
> ---------- Forwarded message ----------
> From: Henry Minsky < [EMAIL PROTECTED]>
> Date: Oct 30, 2006 9:53 PM
> Subject: for review, more SVG runtime integration
> To: P T Withington <[EMAIL PROTECTED]>
>
> http://svn.openlaszlo.org/openlaszlo/patches/20061031-hqm-4.tar
> Change 20061031-hqm-4 by [EMAIL PROTECTED] on 2006-10-31 00:46:52 PST
> in /cygdrive/c/users/hqm/openlaszlo/branches/legals
>
> Summary: more SVG runtime integration
>
> New Features:
>
> svg wrappers, updates to kernel
>
> Bugs Fixed:
>
> Technical Reviewer: (pending)
> QA Reviewer: (pending)
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details:
>
> converted a bunch of '$dhtml' compile time conditionals to $js1,
> changed swf conditional arms to $as2
>
> just copied placeholder for mouse and keyboard kernel
>
>
> Tests:
>
> smoke, lztest, calendar, lzpix
>
> Files:
> A WEB-INF/lps/lfc/kernel/svg/LzKeyboardKernel.js
> M WEB-INF/lps/lfc/kernel/svg/LzSprite.js
> A WEB-INF/lps/lfc/kernel/svg/LzMouseKernel.js
> M WEB-INF/lps/lfc/kernel/svg/Library.lzs
> M WEB-INF/lps/lfc/kernel/svg/LzTextSprite.js
> M WEB-INF/lps/lfc/kernel/Library.lzs
> M WEB-INF/lps/lfc/services/Library.lzs
> M WEB-INF/lps/lfc/debugger/Library.lzs
> M WEB-INF/lps/lfc/debugger/LzBacktrace.lzs
> M WEB-INF/lps/lfc/core/LzNode.lzs
> A WEB-INF/lps/lfc/views/platform/svg
> A WEB-INF/lps/lfc/views/platform/svg/LzPlatform.js
> M WEB-INF/lps/lfc/views/Library.lzs
> M WEB-INF/lps/lfc/helpers/Library.lzs
> M WEB-INF/lps/lfc/data/LzDatapointer.lzs
> M WEB-INF/lps/lfc/data/Library.lzs
> M WEB-INF/lps/lfc/compiler/LzRuntime.lzs
> M WEB-INF/lps/server/sc/lzsc.py
> M WEB-INF/lps/server/src/org/openlaszlo/compiler/Compiler.java
> M WEB-INF/lps/server/src/org/openlaszlo/compiler/Main.java
> A WEB-INF/lps/templates/svg-response.xslt
> A WEB-INF/lps/templates/svgwrapper- response.xslt
> Remember to mail your reviewers and cc [email protected]
>
> --
> Henry Minsky
> Software Architect
> [EMAIL PROTECTED]
>
>
>
> --
> Henry Minsky
> Software Architect
> [EMAIL PROTECTED]
--
Henry Minsky
Software Architect
[EMAIL PROTECTED]
|
