Re: [Laszlo-dev] For Review: Change 20061101-ptw-6 Summary: Permit special URL characters in change note

Wed, 01 Nov 2006 10:56:22 -0800 

Approved!

-Max

P T Withington wrote:

Change 20061101-ptw-6 by [EMAIL PROTECTED] on 2006-11-01 13:19:04 EST
    in /Users/ptw/OpenLaszlo/tools/trunk/svn

Summary: Permit special URL characters in change note

Bugs Fixed:
LPP-2995 svn-review fails to append the svn URL when details: and test: lines are filled in 

Technical Reviewer: ben (pending)
QA Reviewer: max (pending)
Doc Reviewer: n/a

Details:
    If your review message contained '?'s or '&'s, they were not being
    properly escaped before being turned into the mailto: url, causing
    the url to get truncated (and your message to be corrupted).

Tests:
    This comment:

    "Comparing
    http://legals/test/lztest/lztest-textheight.lzx?lzr=dhtml&debug=true vs
    http://legals/test/lztest/lztest-textheight.lzx?lzr=swf7&debug=true
    should pass in swf and dhtml and should be visually
    identical. also,
    http://legals/examples/components/edittext_example.lzx?lzr=dhtml allows
    the enter key in multiline text and password fields show ***."

    Should not cause this change note to be truncated when sent for
    review.

Files:
M      svn-bash.sh
M      review-mail.pl

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20061101-ptw-6.tar

Reply via email to