I don't see why this is necessary. The list of files that are tar-ed
comes from the change description, so tar should not be including
any .svn directories in the first place. Do you have a test that
demonstrates otherwise?
I'd approve on the basis that your change is a no-op, but I suspect
there is a different problem here if tar was being asked to
include .svn files. I rather suspect that the `sed ...` explodes or
returns an empty string for some reason causing tar to think it
should tar everything in the directory. If that is the case, we need
to protect against that, not just exclude .svn files.
On 2006-11-02, at 21:36 EST, Benjamin Shine wrote:
Change 20061102-ben-5 by [EMAIL PROTECTED] on 2006-11-02 18:29:46 PST
in /Users/ben/src/svn/tools/trunk/svn
Summary: Exclude .svn directories when adding files
New Features:
Bugs Fixed: Adding directories with svn add followed by svn-commit
sent bad change packages (no bug number)
Technical Reviewer: ptw (pending)
QA Reviewer: (pending)
Doc Reviewer: (pending)
Documentation:
Directories named .svn should not be included in changesets. They have
a lot of extra data in them which is not helpful to distribute, and
sometimes even destructive. (It's destructive if it overwrites a .svn
directory in your working copy which had important local information.)
Release Notes:
Details:
Tests:
svn-newchange, svn-editchange, svn-review
then look at the posted tar. It should not have any .svn
directories in it.
Files:
M svn-bash.sh
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20061102-
ben-5.tar
Benjamin Shine
Software Engineer, Open Laszlo / Laszlo Systems
[EMAIL PROTECTED]
