Comments:
1. Did you verify that your wrapper page still validates?
2. embed-dhtml.js does not require any minimum Javascript version?
3. The references to flashvars, embed and object in embed-dhtml are
confusing.
4. I am queasy about the unconditional setting of globals from query
vars. Could this not clobber browser globals, potentially making our
wrapper a conduit for an injection attack?
5. I think it would be useful to move the comment that the LFC
requires js 1.5 from the xslt template to where it is now specified
in embed.
6. I have a mild aversion to LzEmbed returning both the LFC and the
app -- consider someone embedding more than one app in the same page.
Approved if you address my comments!
On 2006-11-01, at 12:46 EST, Max Carlson wrote:
Change 20061101-maxcarlson-p by [EMAIL PROTECTED]
computer.local on 2006-11-01 09:44:21 PST
in /Users/maxcarlson/openlaszlo/legals
Summary: Add basic LzEmbed implementation to DHTML.
New Features:
Bugs Fixed: LPP-2812 - Need an implementation of lzEmbed to DHTML,
LPP-2781 - Support access to queryArgs from DHTML global space
Technical Reviewer: ptw
QA Reviewer: jgrandy
Doc Reviewer: (pending)
Documentation:
Release Notes:
Details: This matches the SWF implementation, setting global
variables for all query args. Moved logic to embed.js and cleared
cruft out of LFC.js
Tests: running http://localhost:8080/legals/demos/lzpix/app.lzx?
foo=bar&lzr=dhtml&debug=true and typing 'foo' into the debugger
should yield the extra query arg. Only LPS-specific query args are
sent to the server. Laszlo-explorer continues to work.
Files:
M WEB-INF/lps/lfc/kernel/dhtml/LFC.js
M WEB-INF/lps/templates/html-response.xslt
A lps/includes/embed-dhtml.js
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20061101-
maxcarlson-p.tar
