Approved.
On Nov 7, 2006, at 11:06 AM, Benjamin Shine wrote:
Change 20061107-ben-q by [EMAIL PROTECTED] on 2006-11-07 10:46:50 PST
in /Users/ben/src/svn/openlaszlo/branches/legals
Summary: legals doc build workarounds
New Features: Turn off doc build in legals for mac and windows, and
guard against wrong java version
Bugs Fixed:
Technical Reviewer: jgrandy (pending)
QA Reviewer: mamye (pending)
Doc Reviewer: (pending)
Documentation:
The developer's guide in legals currently requires Java 1.4 to
build. This
change works around that requirement by automatically turning off
the doc build
(using the skip.doc property) if the OS is windows or mac. That is,
the doc
build will only be attempted on linux.
This change also adds a check for the necessary java version. When
the dguide
build is invoked, we first check the java version, and issue a
meaningful error
message if the wrong version of java is present.
Release Notes:
THE DOC WILL NOT BUILD WITH JAVA 1.5. THE DOC WILL ONLY BUILD WITH
JAVA 1.4.
Details:
Tests:
On mac and windows, the doc build is skipped. The next nightly
build should
succeed on mac and windows, or at least, not fail with a doc build
problem.
With java set to 1.5, ant dguide fails with this message:
$ java -version
java version "1.5.0_06"
Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_06-112)
Java HotSpot(TM) Client VM (build 1.5.0_06-64, mixed mode, sharing)
$ ant dguide
Buildfile: build.xml
checkjavaversion:
BUILD FAILED
/Users/ben/src/svn/openlaszlo/branches/legals/docs/src/build.xml:
707: To build the developer's guide, Java 1.4 is required, but
current java version is 1.5. The build will fail now. [bshine
11.06.2006]
With skip.doc set in build.properties, the dguide build is skipped.
Files:
M docs/src/build.xml
M build.properties
M build-tools/build-opt.xml
M build.xml
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20061107-
ben-q.tar
Benjamin Shine
Software Engineer, Open Laszlo / Laszlo Systems
[EMAIL PROTECTED]
