Hi Plhi,

I have a patch out for review - perhaps you'll review it?  Thanks!

Here's a copy of the email I sent out:

Change 20061107-maxcarlson-f by [EMAIL PROTECTED]
computer.local on 2006-11-07 14:10:59 PST
    in /Users/maxcarlson/openlaszlo/legals

Summary: Fix disabled buttons, fix combobox

New Features:

Bugs Fixed: LPP-2869 - Disabled button and data entry fields broken,
LPP-2935 - Make combobox work in Legals

Technical Reviewer: hminsky
QA Reviewer: ptw
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details: Add safety checking to LzModeManager, remove overriding
field in basebutton, add UID to LzSprite


Tests:

Files:
M      WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
M      WEB-INF/lps/lfc/services/LzModeManager.lzs
M      lps/components/base/basebutton.lzx

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20061107-maxcarlson-f.tar

-Max

Philip Romanik wrote:
Hi Max,

I tracked down a dhtml problem when running windows_example:

http://localhost:8080/legals/examples/components/window_example.lzx?lzr=dhtml

In handleMouseEvent() (in LzModeManager.lzx), the value of view can be null after __findInputtextSelection is called. Is it safe to just return in this condition? See my fix below:

Thanks!

Phil

--------------------

LzModeManager.handleMouseEvent= function ( view, eventStr ) {
    ...

    if (view == null ) {  // check if the mouse event is in a inputtext
        view = this.__findInputtextSelection();
    }

    //PBR I added these 2 lines of code as a work-around.
    if (view == null)
      return;

    ....
}

Reply via email to