This is impressive. Some high-level comments:
1. Given the grief that [FlashObject got](http://blog.deconcept.com/
2006/04/21/flashobject-to-become-swfobject/), perhaps we should stomp
the word 'Flash' out of here and use 'SWF' instead?
2. Am I confused, or do we now have `class` declarations in the
kernel (kernel/dojo/*/*.as)? If we are going to permit them there,
why not permit them everywhere in the kernel? I think it would make
our code much cleaner and easier to read.
3. Not sure I understand the purpose of the swf6 support in the
kernel, since Legal's does not support swf6.
4. Something is wonky in kernel/swf/dojo/Library.lzs. The same code
is repeated over and over.
5. Just delete krank bits when you come across them.
6. Shouldn't your <script> tags specify `language`? There must be a
minimum JS level required, no?
7. Wow, flash.js is a boatload of js. How do we track dojo changes
to make sure our version stays current?
8. For future consideration: [document.write does not work in XHTML]
(http://www.w3.org/MarkUp/2004/xhtml-faq#docwrite)
9. You put me down as QA reviewer, but I would like _real_ QA to
verify that the new embedding code works on all target browsers.
Otherwise, approved!
On 2006-11-19, at 02:00 EST, Max Carlson wrote:
Change 20061118-maxcarlson-m by [EMAIL PROTECTED]
computer.local on 2006-11-18 22:54:32 PST
in /Users/maxcarlson/openlaszlo/legals
Summary: Replace embed.js with dojo.flash
New Features:
Bugs Fixed:
Technical Reviewer: hminsky
QA Reviewer: ptw
Doc Reviewer: (pending)
Documentation:
Release Notes:
Details: Swf embedding works in IE, firefox 1.5 win and mac, and
safari
Tests: http://localhost:8080/legals/my-apps/copy-of-hello.lzx?
lzr=swf7&lzt=html , pull up the firebug command line and type:
dojo.flash.comm.getCanvasAttribute('lpsbuild') - you should see the
build id. You can also read other canvas attributes.
Files:
A WEB-INF/lps/lfc/kernel/swf/dojo
A WEB-INF/lps/lfc/kernel/swf/dojo/flash6
A WEB-INF/lps/lfc/kernel/swf/dojo/flash6/DojoExternalInterface.as
A WEB-INF/lps/lfc/kernel/swf/dojo/flash8
A WEB-INF/lps/lfc/kernel/swf/dojo/flash8/DojoExternalInterface.as
A WEB-INF/lps/lfc/kernel/swf/dojo/flash8/ExpressInstall.as
M WEB-INF/lps/lfc/kernel/swf/Library.lzs
M WEB-INF/lps/lfc/kernel/Library.lzs
M WEB-INF/lps/lfc/services/LzHistory.as
M WEB-INF/lps/lfc/LaszloLibrary.lzs
M WEB-INF/lps/server/src/org/openlaszlo/compiler/SWFFile.java
M WEB-INF/lps/templates/html-response.xslt
M WEB-INF/lps/templates/app-console.xslt
M lps/includes/embed.js
A lps/includes/flash.js
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20061118-
maxcarlson-m.tar
