Thanks.

I'll rename the targets as you suggest.

The "warnings" are expected -- when all you have is a red flag...

I'll check in and then try to build against 1.65 -- maybe it'll work!

jim

On Dec 4, 2006, at 10:53 AM, Benjamin Shine wrote:


THIS IS GORGEOUS.

In build.xml, it's kind of weird to have a target named lfc.html because that looks just like a filename. We don't have a standard for what we use dots for in ant target names, though, and I see where lfc.html parallels lfc.dbk. Maybe make the target names lfc.html.generate and lfc.docbook.generate?


Are these warnings normal and expected?
[style] file:/Users/ben/src/svn/vendor/docbook-xsl-1.65.1/html/ chunker.xsl:94:18: Warning! Writing LzInputTextSprite_+as2_-dhtml_- svg.html for refentry(LzInputTextSprite_+as2_-dhtml_-svg) [style] file:/Users/ben/src/svn/vendor/docbook-xsl-1.65.1/html/ chunker.xsl:94:18: Warning! Writing LzInputTextSprite_+dhtml.html for refentry(LzInputTextSprite_+dhtml) [style] file:/Users/ben/src/svn/vendor/docbook-xsl-1.65.1/html/ chunker.xsl:94:18: Warning! Writing LzInstantiator.html for refentry (LzInstantiator)
... repeat.

and
[style] file:/Users/ben/src/svn/vendor/docbook-xsl-1.65.1/html/ synop.xsl:656:20: Warning! Unrecognized language on classsynopsis: javascript
...repeat

And, to beat a dead horse with a paperclip, does this require docbook-xsl-1.71, or other recent changes to jars? It's building on my local machine but I'm going to have to make sure it works on linux-builder.

Mostly approved like mad! If the warnings are okay, check it in, and I'll start making sure it flies on linux-builder.

-ben





On Dec 4, 2006, at 2:30 AM, Jim Grandy wrote:

Change 20061204-jgrandyw-A by [EMAIL PROTECTED] on 2006-12-04 02:21:05 PST
    in /Users/jgrandyw/dev/svn/openlaszlo/branches/legals

Summary:More improvements to js2doc and LFC Reference. It's now almost usable!

Bugs Fixed:LPP-1436 LPP-1438

Technical Reviewer: ben
QA Reviewer:
Doc Reviewer: jsundman

Details:LFC Reference is still turned off, and js2doc shouldn't build as part of the LPS server either. But lots of progress: most of the right information is making it into docbook format and from there into HTML. I'm using a mutated variant of Oliver's html2dbk.xsl to convert from the kind of weird HTML folks use in javadoc-style comments, and I'm using the same stylesheet and Docbook customizations used by the DGuide et al. (For all the good that's doing me -- they don't handle reference entries very well at all.) Missing pieces: much of the commentary in the LFC is not in the correct format, so it doesn't make it to the docs. The index is quite complete but doesn't link back into the text yet. Cross-linking within the Reference is spotty. And there are many small items to fix up. But I think its reasonably usable! Next step after this
checkin: turn it on.

If I wasn't clear: the output is really quite ugly right now. It will get better.

Tests: 'cd docs/src ; ant -buildfile build-lfc.xml lfc.html ; open ../reference/index.html'

Files:
M      WEB-INF/lps/lfc/kernel/svg/LFC.js
M      WEB-INF/lps/lfc/kernel/svg/LzRequires.js
M      WEB-INF/lps/lfc/kernel/svg/LzKeyboardKernel.js
M      WEB-INF/lps/lfc/kernel/svg/LzHTTPLoader.js
M      WEB-INF/lps/lfc/kernel/svg/LzSprite.js
M      WEB-INF/lps/lfc/kernel/svg/LzMouseKernel.js
M      WEB-INF/lps/lfc/kernel/svg/LzPool.js
M      WEB-INF/lps/lfc/kernel/svg/Library.lzs
M      WEB-INF/lps/lfc/kernel/svg/LzXMLTranslator.js
M      WEB-INF/lps/lfc/kernel/svg/LzInputTextSprite.js
M      WEB-INF/lps/lfc/kernel/svg/LzTextSprite.js
M      WEB-INF/lps/lfc/kernel/svg/LzXMLParser.js
M      WEB-INF/lps/lfc/kernel/swf/LzFunctions.as
M      WEB-INF/lps/lfc/kernel/swf/LzSoundMC.as
M      WEB-INF/lps/lfc/kernel/swf/LzLibrary.lzs
M      WEB-INF/lps/lfc/kernel/swf/LzXMLTranslator.as
M      WEB-INF/lps/lfc/kernel/swf/LzMediaLoader.lzs
M      WEB-INF/lps/lfc/kernel/swf/LzLoader.lzs
M      WEB-INF/lps/lfc/kernel/swf/LzTextSprite.as
M      WEB-INF/lps/lfc/kernel/swf/LzXMLParser.as
M      WEB-INF/lps/lfc/kernel/swf/LzLibraryCleanup.lzs
M      WEB-INF/lps/lfc/kernel/swf/LzLoadQueue.as
M      WEB-INF/lps/lfc/kernel/swf/LzMouseKernel.as
M      WEB-INF/lps/lfc/kernel/swf/LzInputTextSprite.as
M      WEB-INF/lps/lfc/kernel/swf/LzRequires.as
M      WEB-INF/lps/lfc/kernel/swf/LzLibraryLoader.lzs
M      WEB-INF/lps/lfc/kernel/swf/LzKeyboardKernel.as
M      WEB-INF/lps/lfc/kernel/swf/LzFontManager.as
M      WEB-INF/lps/lfc/kernel/swf/LzAudio.as
M      WEB-INF/lps/lfc/kernel/swf/Library.lzs
M      WEB-INF/lps/lfc/kernel/swf/LzMakeLoadSprite.as
M      WEB-INF/lps/lfc/kernel/swf/LzHTTPLoader.as
M      WEB-INF/lps/lfc/kernel/swf/LzSprite.as
M      WEB-INF/lps/lfc/kernel/dhtml/LFC.js
M      WEB-INF/lps/lfc/kernel/dhtml/LzRequires.js
M      WEB-INF/lps/lfc/kernel/dhtml/LzKeyboardKernel.js
M      WEB-INF/lps/lfc/kernel/dhtml/LzHTTPLoader.js
M      WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
M      WEB-INF/lps/lfc/kernel/dhtml/LzMouseKernel.js
M      WEB-INF/lps/lfc/kernel/dhtml/LzPool.js
M      WEB-INF/lps/lfc/kernel/dhtml/Library.lzs
M      WEB-INF/lps/lfc/kernel/dhtml/LzXMLTranslator.js
M      WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js
M      WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js
M      WEB-INF/lps/lfc/kernel/dhtml/LzXMLParser.js
M      WEB-INF/lps/lfc/kernel/Library.lzs
M      WEB-INF/lps/lfc/kernel/LzIdleKernel.lzs
M      WEB-INF/lps/lfc/kernel/LzRequires.lzs
M      WEB-INF/lps/server/src/org/openlaszlo/js2doc/Schema_Test.java
M WEB-INF/lps/server/src/org/openlaszlo/js2doc/tests/ test_include.xml M WEB-INF/lps/server/src/org/openlaszlo/js2doc/tests/ unitcomment.xml M WEB-INF/lps/server/src/org/openlaszlo/js2doc/tests/ unitcomment2.xml M WEB-INF/lps/server/src/org/openlaszlo/js2doc/tests/ LaszloEvents.js M WEB-INF/lps/server/src/org/openlaszlo/js2doc/tests/ LaszloEvents.xml M WEB-INF/lps/server/src/org/openlaszlo/js2doc/tests/ shortest.xml M WEB-INF/lps/server/src/org/openlaszlo/js2doc/tests/ simplecomment.xml
M      WEB-INF/lps/server/src/org/openlaszlo/js2doc/JS2Doc_Test.java
M      WEB-INF/lps/server/src/org/openlaszlo/js2doc/JS2Doc.java
M      WEB-INF/lps/server/src/org/openlaszlo/js2doc/js2doc.rnc
M      WEB-INF/lps/server/build.xml
M      docs/src/build-lfc.xml
A      docs/src/xsl/js2doc-comment2dbk.xsl
M      docs/src/xsl/js2doc2dbk.xsl

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20061204- jgrandyw-A.tar

Benjamin Shine
Software Engineer, Open Laszlo / Laszlo Systems
[EMAIL PROTECTED]




Reply via email to