Re: [Laszlo-dev] 2 things broken on dhtml legals

[Jim Grandy]

Great! It's safe to just revert them, since that just means I collect  
less documentation for those files. Please go ahead and submit a  
change and get it approved -- don't worry about any effects on the  
refguide.

jim
On Dec 9, 2006, at 5:43 PM, Philip Romanik wrote:

Yes, it is 2989. I tracked down 3 files that look a little funny  
because it isn't just a comment change. When I revert these files  
to before 2989 my 2 errors go away:

data/LzDatapointer.lzs
data/LzDataset.lzs
data/LzDatapath.lzs


Are you sure? That change shouldn't have affected the lfc or
anything. It just properly turns off the refguide build!


jgrandy-pb:~/dev/svn/openlaszlo/branches/legals jgrandyw$ svn diff -r
2989
Index: docs/src/build.xml  
===================================================================
--- docs/src/build.xml  (revision 2989)
+++ docs/src/build.xml  (working copy)
@@ -192,11 +192,17 @@
    <target name="lfc.dbk.dep">
      <!-- essentially a copy of the same target in ${lfc.dir}/
build.xml, but I'm
           not sure what else to do -->
-    <uptodate property="lfc.dbk.uptodate" targetfile="$ 
{lfc.dbk.dir}/
LaszloLibrary.dbk">
-        <srcfiles dir="${lfc.dir}" includes="**/*.lzs" />
-        <srcfiles dir="${lfc.dir}" includes="**/*.as" />
-        <srcfiles dir="${lfc.dir}" includes="**/*.js" />
-    </uptodate>
+   <echo message="skip.doc.reference is ${skip.doc.reference}"/>
+    <condition property="lfc.dbk.uptodate">
+        <or>
+          <isset property="skip.doc.reference"/>
+          <uptodate targetfile="${lfc.dbk.dir}/LaszloLibrary.dbk">
+            <srcfiles dir="${lfc.dir}" includes="**/*.lzs" />
+            <srcfiles dir="${lfc.dir}" includes="**/*.as" />
+            <srcfiles dir="${lfc.dir}" includes="**/*.js" />
+          </uptodate>
+        </or>
+    </condition>
    </target>

    <target name="reference" description="Build the reference"
Index: build-tools/build-opt.xml  
===================================================================
--- build-tools/build-opt.xml   (revision 2989)
+++ build-tools/build-opt.xml   (working copy)
@@ -66,7 +66,7 @@
      <property name="skip.prefetch" value="true" />
      <!-- property name="skip.wrappertest" value="true" -->
      <!-- <property name="skip.runlzunit" value="true" -->
-    <property name="skip.doc.reference" value="true" />
+<?ignore    <property name="skip.doc.reference" value="true" /> ?>

      <property name="done.build-opt" value="true" />
</target>

jim

On Dec 9, 2006, at 3:31 PM, P T Withington wrote:

> Gah!
>
> On 2006-12-09, at 18:07 EST, Philip Romanik wrote:
>
>> The error is coming from 2989, one of Jim's comment-change  
updates.
>>
>> 2988 doesn't show the error, and 2989 does.
>>
>>
>>> I did a clean checkout/build and got the same behavior. Must be a
>>> Windows
>>> issue.
>>>
>>> Phil
>>>
>>> >Weird.  I am not seeing it in my playpen.
>>> >
>>> >On 2006-12-09, at 16:22 EST, Philip Romanik wrote:
>>> >
>>> > > Hi Tucker,
>>> > >
>>> > > I applied both and they don't address this issue. I'll see if
>>> I can
>>> > > narrow the problem down a bit. These problems crept in during
>>> the
>>> > > past couple of days.
>>> > >
>>> > >
>>> > > Phil
>>> > >
>>
>