Yes, indeed, just not in a rush.
On Dec 12, 2006, at 11:43 AM, P T Withington wrote:
Ok. I am still in favor of adding back the declarations when we
can preserve semantics.
On 2006-12-12, at 12:47 EST, Jim Grandy wrote:
Maybe I wasn't completely clear -- without backing out these
files, r2988:2989 breaks calendar in branches/4.0b1. I thought it
also broke it in legals, but possibly not. I think it's the right
thing to do in any case -- I think I moved forward too fast by
modifying the declarations in those files, and I'd like to step
back and focus instead on comment-level changes.
jim
On Dec 12, 2006, at 9:35 AM, P T Withington wrote:
I have just one question: dhtml calendar works fine for me in
[EMAIL PROTECTED] without this change, so I'm not sure why we need to
revert?
On 2006-12-12, at 10:18 EST, Philip Romanik wrote:
approved.
(Tucker, I verified the changes were reverted to the previous
version and the calendar app runs fine in dhtml.)
Change 20061212-jgrandyw-o by [EMAIL PROTECTED] on
2006-12-12
00:47:26 PST
in /Users/jgrandyw/dev/svn/openlaszlo/branches/legals
Summary: Back out other non-comment changes to LFC and schema in
r2988:2989
Bugs Fixed:LPP-3303
Technical Reviewer: ptw
QA Reviewer: pbr
Doc Reviewer:
Details:To be safe, just back out the remaining non-comment
changes
that were still
in the build after 3014 reverted two files. One of the changes was
causing the Calendar
to fail to load.
Tests:'ant clean ; svn up ; ant build doc test' -- verify that
Calendar loads again in DHTML.
Files:
M WEB-INF/lps/lfc/core/LzNode.lzs
M WEB-INF/lps/lfc/views/LaszloView.lzs
M WEB-INF/lps/lfc/events/LaszloEvents.lzs
M WEB-INF/lps/lfc/controllers/LzAnimatorGroup.lzs
M WEB-INF/lps/lfc/controllers/LaszloLayout.lzs
M WEB-INF/lps/server/src/org/openlaszlo/js2doc/js2doc.rnc
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20061212-
jgrandyw-o.tar
