Which browser does it fail under? Your change looks good - approved, if
you'll review the change I just sent you and Jim :)
--
Regards,
Max Carlson
OpenLaszlo.org
Philip Romanik wrote:
Hi Max,
Running the unit test generates an error, but it generates it when I
back out my change:
ERROR: In suite Text Size Test Suite, test 1, failed assertion: FAIL:
inputtext5 heightEquals expected 52, got 54
Sorry about the missing link. I must have cut the last line off:
Changeset:
http://svn.openlaszlo.org/openlaszlo/patches/20070101-Philip-2.tar
Philip Romanik wrote:
> Change 20070101-Philip-2 by [EMAIL PROTECTED] on 2007-01-01 16:13:41 EST
> in /cygdrive/f/laszlo/svn/src/svn/openlaszlo/branches/legals
>
> Summary: Modify view/text methods to match documented behavior.
>
> New Features:
>
> Bugs Fixed: LPP-3376
>
> Technical Reviewer: max
> QA Reviewer: (pending)
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details:
> In LzView, modified sendInFrontOf() and sendToBack() to accept a null
> argument. This matches the documented behavior of the method (and it's
> called this way from the charting package).
>
> In LzText, modified setFontName() and setFontSize() to call setText to
> recompute the width and height. This matches the behavior in trunk.
> Without this change, some charting demos display an incorrect border
> around some text labels.
>
> Tests:
> Running the charting tests get further.
>
> Files:
> M WEB-INF/lps/lfc/views/LzText.lzs
> M WEB-INF/lps/lfc/views/LaszloView.lzs
>
I don't see a link for the changeset. Also, did you test these changes
under DHTML? Be sure to run
http://localhost:8080/legals/test/lztest/lztest-textheight.lzx?debug=true
in swf and DHTML.
--
Regards,
Max Carlson
OpenLaszlo.org
