Approved, with one reservation: in build-tools/build-opt.xml, the skip.doc.reference is such a source of confusion that I would prefer not to check in <?ignore ?> directives around the skip.doc.reference property or condition.

Shout-out to two neat tricks:

I did not know you could specify an echo message as tag content, but it's awfully nice that you can. + <echo file="${docs.build.dir}/CatalogManager.properties" append="false">
+catalogs=${docbook-xml}/catalog.xml;${docbook-xsl}/catalog.xml
+relative-catalogs=false
+static-catalog=yes
+catalog-class-name=org.apache.xml.resolver.Resolver
+verbosity=1
+      </echo>

This is also pretty cool, and helps answer's Henry's question, "what does a guy have to do to get an xml parser around here?" <jvmarg value="- Djavax.xml.parsers.DocumentBuilderFactory=org.apache.xerces.jaxp.Documen tBuilderFactoryImpl"/> <jvmarg value="- Djavax.xml.parsers.SAXParserFactory=org.apache.xerces.jaxp.SAXParserFact oryImpl"/> <jvmarg value="- Dorg.apache.xerces.xni.parser.XMLParserConfiguration=org.apache.xerces.p arsers.XIncludeParserConfiguration"/>


On Jan 16, 2007, at 10:17 AM, Jim Grandy wrote:

I was able to apply this patch by doing the following:

> cd docs/src/xsl
> cp print.xsl.proto print.xsl
> cp dguide-chm.xsl.proto dguide-chm.xsl
> cp common-html.xsl.proto common-html.xsl
> cp fast-dguide.xsl.proto fast-dguide.xsl
> cd ../../..
> 20070116-jgrandyw-x/apply.sh

jim

On Jan 16, 2007, at 9:58 AM, Jim Grandy wrote:

Change 20070116-jgrandyw-x by [EMAIL PROTECTED] on 2007-01-16 09:50:30 PST
    in /Users/jgrandyw/dev/svn/openlaszlo/branches/legals2

Summary:Use Schema Resolver to find local copies of schemas and XSL files

New Features:

Bugs Fixed:LPP-3142

Technical Reviewer: ben
QA Reviewer:
Doc Reviewer:

Documentation:

Release Notes:

Details:Not sure if the patch will faithfully express this change.
Intention is that the *.xsl.proto files be moved and modified.

This change creates just a single Catalog.properties file for all
docbook builds. Next step after this change is to switch to using a
single ant task for all the docbook builds -- currently there are three.

Tests:

Files:
M      docs/src/build-dbk.xml
M      docs/src/build.xml
A  +   docs/src/xsl/print.xsl
D      docs/src/xsl/common-html.xsl.proto
D      docs/src/xsl/fast-dguide.xsl.proto
D      docs/src/xsl/dguide-chm.xsl.proto
A  +   docs/src/xsl/common-html.xsl
A  +   docs/src/xsl/fast-dguide.xsl
D      docs/src/xsl/print.xsl.proto
A  +   docs/src/xsl/dguide-chm.xsl
M      build-tools/build-opt.xml

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070116- jgrandyw-x.tar


Benjamin Shine
Software Engineer, Open Laszlo / Laszlo Systems
[EMAIL PROTECTED]



Reply via email to