Approved, too. Thanks, Max.
Any ideas why this was working differently in Flash and DHTML?
On Feb 7, 2007, at 10:02 PM, P T Withington wrote:
Approved. Although I would have preferred `Number(foo)` over `foo
* 1`.
On 2007-02-07, at 19:06 EST, Max Carlson wrote:
Change 20070207-maxcarlson-R by [EMAIL PROTECTED]
computer.local on 2007-02-07 16:04:16 PST
in /Users/maxcarlson/openlaszlo/legals
Summary: Fix baseslider.lzx while passing unit test
New Features:
Bugs Fixed:
Technical Reviewer: jcrowley
QA Reviewer: ptw
Doc Reviewer: (pending)
Documentation:
Release Notes:
Details: Something in Josh's change causes the unit test to fail:
http://localhost:8080/legals/test/components/base/lzunit-
baseslider.lzx
It seems like the example is setting the minvalue/maxvalue based
on the value of a textfield, which is of course a string. It
seems like the right fix is to coerce the values to numbers in the
setter functions instead.
Tests: http://localhost:8080/legals/test/components/base/lzunit-
baseslider.lzx
Files:
M lps/components/base/baseslider.lzx
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070207-
maxcarlson-R.tar
