Approved.
Affter applying this change I tried to do a 'ant doc' and it failed. Any ideas?
ant doc
Buildfile: build.xml
build-opt:
init:
[echo] Ant project:lps on Windows XP 5.1 x86
[echo] ant.home: F:\laszlo\svn\lib\apache-ant-1.6.5
[echo] JRE: 1.5.0_06 (Sun Microsystems Inc.)
[echo] JAVA_HOME: c:\Java
[echo] LPS Version: 4.0.x Latest
[echo] LPS_HOME: F:\laszlo\svn\src\svn\openlaszlo\branches\4.0
[echo] LZ_VENDOR_ROOT: F:\laszlo\svn\src\svn\vendor
[echo] LZ_TOOLS_ROOT: F:\laszlo\svn\src\svn\tools\trunk
[echo] LZ_INSTALLS_ROOT: F:\laszlo\svn\lib
[echo] server.home: c:\Program Files\Apache Software
Foundation\Tomcat 5.0
[echo] lps.branch: 4.0
[echo] platform: is windows
[echo] Skipping prefetch is true
[echo] Skipping wrappertest is ${skip.wrappertest}
[echo] Skipping doc is ${skip.doc}
doc:
build-opt:
init:
[echo] draft.mode=yes
[echo] skip.doc=${skip.doc}
[echo] skip.doc.reference=true
lfc.js2doc.generate:
js2doc.init:
build-opt:
get-svn-info:
setup-build-id:
[echo] build.id is 4152 F:\laszlo\svn\src\svn\openlaszlo\branches\4.0
init:
[echo] sc-parser.uptodate is true
js2doc.rng.dep:
js2doc.rng:
components.js2doc.generate:
incubator.js2doc.generate:
embednew.js2doc.generate:
components.resources.generate:
docbook.catalog.generate:
reference.js2doc.build:
reference.dbk.build:
reference.dbk.generate:
reference.html.dep:
[echo] reference.skip is $reference.skip
reference.html.generate:
reference.resources:
BUILD FAILED
F:\laszlo\svn\src\svn\openlaszlo\branches\4.0\build.xml:556: The following
error occurred while executing this line:
F:\laszlo\svn\src\svn\openlaszlo\branches\4.0\docs\src\build.xml:531:
F:\laszlo\svn\src\svn\openlaszlo\branches\4.0\docs\src\build\reference\images
not found.
Total time: 2 seconds f:\laszlo\svn\src\svn\openlaszlo\branches\4.0>
On 3/8/07, Philip <[EMAIL PROTECTED]> wrote:
>
>
> -----Original Message-----
> From: Max Carlson [mailto:[EMAIL PROTECTED]
> Sent: Thursday, March 08, 2007 1:33 PM
> To: [EMAIL PROTECTED]; Jim Grandy
> Cc: [email protected]
> Subject: For Review: Change 20070308-maxcarlson-W Summary: merge
> -r4127:4128 from legals
>
> Change 20070308-maxcarlson-W by [EMAIL PROTECTED]
> computer.local on 2007-03-08 10:28:48 PST
> in /Users/maxcarlson/openlaszlo/4.0
>
> Summary: merge -r4127:4128 from legals
>
> New Features:
>
> Bugs Fixed:
>
> Technical Reviewer: promanik
> QA Reviewer: jgrandy
> Doc Reviewer: (pending)
>
> Documentation:
> I agree.
>
> On Mar 7, 2007, at 4:46 PM, Max Carlson wrote:
>
> > I propose integrating part of change 4128 over to 4.0.
> >
> > Rewards: Changes to embedding required for docs.
> >
> > Risks: Small.
>
> Release Notes:
>
> Details: svn merge -r4127:4128 http://svn.openlaszlo.org/openlaszlo/
> branches/legals
>
> Tests:
>
> Files:
> M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
> M WEB-INF/lps/templates/app-console.xslt
> M docs/src/xsl/js2doc-comment2dbk.xsl
> M docs/src/xsl/format.xsl
> M docs/src/xsl/doc2dbk.xsl
> M docs/includes/docbook.css
> M docs/includes/styles.css
> M lps/includes/source/embednew.js
> M lps/includes/source/flash.js
> M lps/admin/dev-console.lzx.js
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070308-
> maxcarlson-W.tar
>
>
Change 20070308-maxcarlson-W by [EMAIL PROTECTED]
computer.local on 2007-03-08 10:28:48 PST
in /Users/maxcarlson/openlaszlo/4.0
Summary: merge -r4127:4128 from legals
New Features:
Bugs Fixed:
Technical Reviewer: promanik
QA Reviewer: jgrandy
Doc Reviewer: (pending)
Documentation:
I agree.
On Mar 7, 2007, at 4:46 PM, Max Carlson wrote:
> I propose integrating part of change 4128 over to 4.0.
>
> Rewards: Changes to embedding required for docs.
>
> Risks: Small.
Release Notes:
Details: svn merge -r4127:4128 http://svn.openlaszlo.org/openlaszlo/
branches/legals
Tests:
Files:
M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
M WEB-INF/lps/templates/app-console.xslt
M docs/src/xsl/js2doc-comment2dbk.xsl
M docs/src/xsl/format.xsl
M docs/src/xsl/doc2dbk.xsl
M docs/includes/docbook.css
M docs/includes/styles.css
M lps/includes/source/embednew.js
M lps/includes/source/flash.js
M lps/admin/dev-console.lzx.js
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070308-
maxcarlson-W.tar