Approved!

I did find a problem with gradients but it must have come in from the last set of changes. The charting demos no longer display a pie chart. For example:

http://localhost:8080/legals/test/charts/piechart/test_pie_01.lzx

This is also broken on the 4.0 branch.


Phil


Change 20070312-maxcarlson-H by [EMAIL PROTECTED] on 2007-03-12
16:29:54 PDT
     in /Users/maxcarlson/openlaszlo/legals-clean

Summary: Fix drawview gradients with legacy LZX, dhtml sprite
improvements

New Features:

Bugs Fixed:

Technical Reviewer: promanik
QA Reviewer: jcrowley
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details: LzUtils.js - moved to kernel/.  Added color conversion
routines.

LzSprite.js - Replace LzSprite.prototype references with this where
possible.  Remove old quirks.  Use LzUtils.color.  Improve setOpacity
() performance.

LzTextSprite.js -  Replace LzSprite.prototype references with this
where possible.

Library.lzs - Move LzUtils to kernel/.

LzInputTextSprite.js -  Replace LzSprite.prototype references with
this where possible.  Use LzUtils.color.

drawview.lzx - Use LzUtils.color.  Add LzCanvasGradient
implementation to fix gradient color values for dhtml.

dev-console.lzx.* - Update to latest LFC.


Tests: All apps run as before.  lztest.  http://localhost:8080/legals/
lps/components/incubator/test/roundrect-test.lzx?lzr=dhtml now runs.

Files:
D      WEB-INF/lps/lfc/kernel/dhtml/LzUtils.js
M      WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
M      WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js
M      WEB-INF/lps/lfc/kernel/dhtml/Library.lzs
M      WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js
M      WEB-INF/lps/lfc/kernel/Library.lzs
A  +   WEB-INF/lps/lfc/kernel/LzUtils.lzs
M      lps/components/extensions/drawview.lzx
M      lps/admin/dev-console.lzx.js
M      lps/admin/dev-console.lzx.swf

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070312-
maxcarlson-H.tar

Reply via email to