Approved. There are 2 issues with the changeset to investigate:
- When you navigate away from the page, IE generates an error in
LzSprite.js: 'Type mismatch'
__discardElement()
{
...
garbageBin.appendChild(element);
garbageBin.innerHTML = '';
...
}
I think garbageBin is null at this point and the calls should be placed
within the preceeding:
if (!garbageBin) {}
block.
- The image is now correctly displayed. However, the error and timeout
events still get generated when I click the 'Load' button. This behavior is
present in all dhtml (I saw it in FF too). It works fine in swf.
Change 20070314-maxcarlson-x by [EMAIL PROTECTED] on 2007-03-14
14:07:47 PDT
in /Users/maxcarlson/openlaszlo/legals-clean
Summary: Fix dhtml onerror and ontimeout in IE 7
New Features:
Bugs Fixed: LPP-3658 - IE can't reload image after an error or timeout.
Technical Reviewer: promanik
QA Reviewer: jcrowley
Doc Reviewer: (pending)
Documentation:
Release Notes:
Details: IE doesn't like resourcewidth/height of 0
Tests:
<canvas>
<simplelayout/>
<button onclick="img.setSource('aksjhd');">Error</button>
<button onclick="canvas.medialoadtimeout = 1;">Set timeout to 1</
button>
<button onclick="img.setSource('/legals/test/resources/jpg/
k8s.jpg');">Load</button>
<view name="img">
<method event="onload">
Debug.write('load', this)
</method>
<method event="onerror">
Debug.write('error', this)
</method>
<method event="ontimeout">
Debug.write('timeout', this)
</method>
</view>
</canvas>
Files:
M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070314-
maxcarlson-x.tar
