Then approved!
On Tue, 20 Mar 2007, Sarah Allen wrote:
That's an old bug (can be seen on laszlomail.com with the options menu).
I can't find it in JIRA though, so I'll write it up.
On Tue, Mar 20, 2007 at 9:27 PM, Pablo Kang wrote:
> Fix looks good, but the test case does something weird for me. Open up
> a floating and then resize the browser. The floating lists are no
> longer attached to their attach targets. Was this always broken?
>
> On Tue, 20 Mar 2007, Sarah Allen wrote:
>
>> Pablo,
>>
>> This is the original change that you had reviewed for Ming last week,
>> along with the test file which she updated to actually work, and I
>> added a couple of test case too. Details below for your review.
>>
>> Thanks,
>> Sarah
>>
>> -----------------------------------------------------------------
>>
>> Change 20070320-sallen-6 by [EMAIL PROTECTED] on 2007-03-20 20:54:23
>> PDT
>> in /cygdrive/c/laszlo/svn/openlaszlo/trunk
>> for http://svn.openlaszlo.org/openlaszlo/trunk
>>
>> Summary: LPP-3701 -combobox's list can hang off the edge of the
>> screen
>>
>> Bugs Fixed: LPP-3701 -combobox's list can hang off the edge of the
>> screen
>>
>> Contributed by: Ming-en Cho
>> Technical Reviewer: [EMAIL PROTECTED] (review code)
>> QA Reviewer: (pending)
>> Doc Reviewer: n/a
>>
>> Documentation:
>>
>> Release Notes:
>>
>> Details: fixed test case (broken before checking in) so that the
>> floating list is made visible by a mouse-click which is a typical use
>> case. The floating list is rarely if ever visible initially, which
>> is what the test used to do. Also added two test cases for the
>> normal case of the menu attaching to the buttom and the actual bug
>> that got fixed here, when it would be cropped by the right edge of
>> the screen.
>>
>>
>> Tests: see updated test file
>>
>> Files:
>> M test/components/lz/test-floatinglist.lzx
>> M lps/components/lz/basefloatinglist.lzx
>>
>> Changeset:
>> http://svn.openlaszlo.org/openlaszlo/patches/20070320-sallen-6.tar
>>
