if I'm reading this correctly, svn-update-change would be the same as calling svn-discard-change then svn-newchange, if so I would vote for fewer options where I can understand what each one does. Also, can you please be consistent about the use of dashes (svn-discardchange, rather than svn-discard-change)

Thanks,
Sarah

On Wed, Mar 21, 2007 at  9:36 AM, P T Withington wrote:

svn-newchange just creates a template and append svn status to it (so, all the files that are modified below the current directory).

svn-edit calls svn-newchange if no change is already in progress.

Once a change is in progress, the change text (and files listed in it) drive the rest of the process.

So, rather than editing an existing change, if you modify more files, you could just do svn-newchange to start over.

Which do you think is better: to add svn-update-change or svn- discard-change, or both?

Also note svn-pending, which lists all the changes you have started and not checked in. You can use any of those names as an argument to the svn-* commands, so you can have multiple changes at once if you like.

On 2007-03-21, at 09:47 EDT, Sarah Allen wrote:

I did read your previous edits to the README, which look good overall, although I'm still unclear what svn-newchange does.... it seems to pick up files I've modified which aren't included in the current changeset.... where is all this magic happening? is it keeping a list somewhere?


On Wed, Mar 21, 2007 at  5:23 AM, P T Withington wrote:

On 2007-03-21, at 01:22 EDT, Sarah Allen wrote:


On Sun, Mar 18, 2007 at  8:26 PM, P T Withington wrote:

4) svn-newchange

Not necessary if you don't have any changes yet, as 5 will make a new change if you don't specify one.

It may be worth mentioning in the README that this step takes many minutes on Windows when executed from $LPS_HOME. (or is it just me?)

It does, but after that, your change is driven by the change file, so it never has to look at your whole filesystem again.

Something that may not be obvious: Once you say new change, it gets the modified files at that point. If you modify more files later, you will have to manually add them to the changeset (or discard your change and start over). After new change, the whole process is driven by the list of files in the change description.

How do you manually add a file to the changeset or discard changes and start over?

What I do:

svn status

and copy the output

svn-edit

and paste the copy over the list of files that were in the change.

Clearly this needs improvement. Probably we should provide svn- update-change or something.

It takes it from your shell $EDITOR variable. This is part of the revised doc I would like to check in...

I tried
%export EDITOR=vim

no luck :(

You need to ask another windows weenie how they do it.

I updated the README (and tools), with all the previous discussion. If you update, perhaps you could review my changes to the README? I'll add these notes today.

Reply via email to