Approved! Go ahead and check 'er in. If you need a hand with this, let
me know!
Dan Stowell wrote:
More comprehensive diff attached - there was a change to the test as well.
-------- Begin forwarded message --------
Subject: Components dude?
Date: 3/26/2007 1:24:42 PM
From: Dan Stowell <[EMAIL PROTECTED]>
To: Max Carlson <[EMAIL PROTECTED]>, Ben Shine <[EMAIL PROTECTED]>
I've got a quick change for scrolledittext in trunk (never
got moved over from lps-pave) - are either of you still in charge of
components?
+++ lps/components/incubator/scrolledittext.lzx (working copy)
@@ -112,6 +112,17 @@
this.myDel = new LzDelegate(this,
"setvscrollwidthfromvisibility", this._vs, "onvisible");
</method>
+ <!--- Overrides a parent method which calculates y position for text
+ in a way that doesn't make sense for this class. We just
trap the
+ call and do nothing. This field is positioned in y by the
constraint
+ y=${parent.border}
+ Note: although this method is a no-op, it still has to be
declared,
+ so the parent class's method does not get called on
instances of
+ this class.
+ -->
+ <method name="_placeTextY">
+ </method>
+
</class>
</library>
------------------------------------------------------------------------
Index: scrolledittext.lzx
===================================================================
--- scrolledittext.lzx (revision 4492)
+++ scrolledittext.lzx (working copy)
@@ -112,6 +112,17 @@
this.myDel = new LzDelegate(this, "setvscrollwidthfromvisibility", this._vs,
"onvisible");
</method>
+ <!--- Overrides a parent method which calculates y position for text
+ in a way that doesn't make sense for this class. We just trap the
+ call and do nothing. This field is positioned in y by the constraint
+ y=${parent.border}
+ Note: although this method is a no-op, it still has to be declared,
+ so the parent class's method does not get called on instances of
+ this class.
+ -->
+ <method name="_placeTextY">
+ </method>
+
</class>
</library>
Index: test/scrolledittext-test.lzx
===================================================================
--- test/scrolledittext-test.lzx (revision 4492)
+++ test/scrolledittext-test.lzx (working copy)
@@ -10,7 +10,7 @@
<view>
<simplelayout axis="y" spacing="6"/>
- <scrolledittext name="set1" x="20" y="20" width="300" height="200">this is
the fun scrolledittext</scrolledittext>
+ <scrolledittext name="set1" x="20" y="20" width="300" height="200"
vscrollbarclassname="newvscrollbar">this is the fun scrolledittext</scrolledittext>
<button>Wider
<handler name="onclick">this.parent.set1.setAttribute("width",
350);</handler>
</button>
--
Regards,
Max Carlson
OpenLaszlo.org
