[Laszlo-dev] For Review: Change 20070327-ptw-7 Summary: DHTML compiler signals parse errors properly

[P T Withington]

Change 20070327-ptw-7 by [EMAIL PROTECTED] on 2007-03-27  
08:10:38 EDT
    in /Users/ptw/OpenLaszlo/legals-1
    for http://svn.openlaszlo.org/openlaszlo/branches/legals
Summary: DHTML compiler signals parse errors properly

Bugs Fixed:
LPP-3758 'Java stack trace while compiling malformed JavaScript code'

Technical Reviewer: hminsky (pending)
QA Reviewer: max (pending)
Doc Reviewer: n/a

Details:
    Compiler: Set pathname on ParseException, to make up for javacc
    shortcoming

    DHTMLWriter: Trampoline compiler exceptions into errors.

    CompilationEnvironment: Pass source locations to script compiler.
    Canonicalize pathnames when adjusting.

    CompilationError: Take file and location from ParseException's.

    Parser.jjt: Make pathname public.

    ParseException: Add an interface to hold the pathname.

Tests:
    Test case from bug report

Files:
M      WEB-INF/lps/server/src/org/openlaszlo/sc/Compiler.java
M      WEB-INF/lps/server/src/org/openlaszlo/compiler/DHTMLWriter.java
M      WEB-INF/lps/server/src/org/openlaszlo/compiler/ 
CompilationEnvironment.java
M      WEB-INF/lps/server/src/org/openlaszlo/compiler/ 
CompilationError.java
M      WEB-INF/lps/server/sc/src/org/openlaszlo/sc/Parser.jjt
M      WEB-INF/lps/server/sc/src/org/openlaszlo/sc/parser/ 
ParseException.java

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070327- 
ptw-7.tar