Approved.
I do get a different set of error messages when running
lztest-textheight.lzx on FF and IE (both on Windows). I don't think this is
related to the change.
IE 6/7:
ERROR: In suite Text Size Test Suite, test 1, failed assertion: FAIL:
text12 heightEquals expected 277, got 225
ERROR: In suite Text Size Test Suite, test 1, failed assertion: FAIL:
text12 text.heightEquals expected 277, got 225
ERROR: In suite Text Size Test Suite, test 1, failed assertion: FAIL:
inputtext5 heightEquals expected 52, got 54
ERROR: In suite Text Size Test Suite, test 1, failed assertion: FAIL:
inputtext5.heightEquals expected 52, got 54
ERROR: In suite Text Size Test Suite, test 1, failed assertion: FAIL:
multiline7 inputtext heightEquals expected 56, got 58
ERROR: In suite Text Size Test Suite, test 1, failed assertion: FAIL:
multiline7 inputtext.heightEquals expected 56, got 58
ERROR: In suite Text Size Test Suite, test 2, failed assertion: FAIL:
inputtext5 widthEquals expected 17, got 37
ERROR: In suite Text Size Test Suite, test 2, failed assertion: FAIL:
inputtext5.widthEquals expected 17, got 37
FF 1.5/2.0
ERROR: In suite Text Size Test Suite, test 1, failed assertion: FAIL:
text12 heightEquals expected 277, got 225
ERROR: In suite Text Size Test Suite, test 1, failed assertion: FAIL:
text12 text.heightEquals expected 277, got 225
ERROR: In suite Text Size Test Suite, test 1, failed assertion: FAIL:
inputtext5 heightEquals expected 52, got 54
ERROR: In suite Text Size Test Suite, test 1, failed assertion: FAIL:
inputtext5.heightEquals expected 52, got 54
Change 20070327-maxcarlson-w by [EMAIL PROTECTED] on 2007-03-27
02:03:07 PDT
in /Users/maxcarlson/openlaszlo/legals-clean
for http://svn.openlaszlo.org/openlaszlo/branches/legals
Summary: UPDATED - Fix text height measurement for multiline text
New Features:
Bugs Fixed: LPP-3774 - Dynamically created multiline text has
incorrect height
Technical Reviewer: promanik
QA Reviewer: hminsky
Doc Reviewer: (pending)
Documentation:
Release Notes:
Details: lztest-textheight.lzx - Update unit test to include test
for LPP-3774.
LzTextSprite.js - Call getTextSize() when measured height is 2. This
fixes the original problem without breaking anything else.
Tests: http://localhost:8080/legals/test/lztest/lztest-textheight.lzx?
lzr=dhtml&debug=true runs in DHTML as it did before r4486. It was
seriously broken in the last version of this fix - should have
updated and ran the unit test in the first place :(. Where would we
be without unit tests?
Files:
M test/lztest/lztest-textheight.lzx
M WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070327-
maxcarlson-w.tar
