that's much easier. Thanks for the tip :)
might be nice to include these steps in the svn tools README.txt
On Tue, Mar 27, 2007 at 11:01 AM, Jim Grandy wrote:
Tthe *easy* resolution would have been to apply the script from the
root of the source tree. This practice works consistently for me
across many code reviews.
cd $LPS_HOME
curl -O http://svn.openlaszlo.org/openlaszlo/patches/20070326-
jgrandyw-J.tar
tar xvf 20070326-jgrandyw-J.tar
20070326-jgrandyw-J.tar/apply.sh
On Mar 27, 2007, at 9:50 AM, Sarah Allen wrote:
that was it! thanks.
On Tue, Mar 27, 2007 at 9:35 AM, J Crowley wrote:
Er, also, I think the issue you're seeing might be from having your
files.tar and apply script in the wrong location. You'll need to
copy them to $LPS_HOME (or, if the package was created from
somewhere other than $LPS_HOME, then the appropriate spot - you can
untar if it doesn't work and see what the directory was from where
the package was created), and then run the apply script. Though,
even then, there can still be some bugginess, which is why I've
been just manually untarring.
On Mar 27, 2007, at 11:44 AM, Sarah Allen wrote:
I tried to apply this change to verify that the bugs are resolved,
but I'm seeing an error from the apply script:
/cygdrive/c/laszlo/svn/openlaszlo/branches/3.4
$ tar -xvf 20070326-jgrandyw-J.tar
20070326-jgrandyw-J/
20070326-jgrandyw-J/apply.sh
20070326-jgrandyw-J/change.txt
20070326-jgrandyw-J/files.tar
$ cd 20070326-jgrandyw-J
$ ls
apply.sh change.txt files.tar
$ ./apply.sh
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: test/components/lz/test-floatinglist.lzx
|===================================================================
|--- test/components/lz/test-floatinglist.lzx (revision 4497)
|+++ test/components/lz/test-floatinglist.lzx (working copy)
--------------------------
File to patch:
what did I do wrong?
Thanks,
Sarah
On Mon, Mar 26, 2007 at 10:32 PM, Jim Grandy wrote:
Change 20070326-jgrandyw-J by [EMAIL PROTECTED] on
2007-03-26 16:35:27 PDT
in /Users/jgrandyw/dev/svn/openlaszlo/branches/3.4
for http://svn.openlaszlo.org/openlaszlo/branches/3.4
Summary:Integrate changes r4409, r4438, r4468, r4472, r4475,
r4462, r4499 from trunk to branches/3.4
New Features:
Bugs Fixed:
Technical Reviewer: sallen
QA Reviewer: adam
Doc Reviewer:
Documentation:
Release Notes:
Details:
Tests:
Files:
M test/components/lz/test-floatinglist.lzx
A + test/text/mouse_events.lzx
M WEB-INF/lps/lfc/services/LzModeManager.as
M WEB-INF/lps/lfc/views/LzText6.as
M WEB-INF/lps/lfc/data/LzDataNode.as
M lps/components/lz/basefloatinglist.lzx
M lps/components/incubator/tooltip/tooltip.lzx
M lps/components/incubator/test/tooltip-test.lzx
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/ 20070326-
jgrandyw-J.tar
